Giter Club home page Giter Club logo

application-yaga's People

Contributors

bleistivt avatar daigo75 avatar hgtonight avatar kasperisager avatar lungyiing avatar multplaneta avatar r-j avatar tburry avatar wrokred avatar x00 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

application-yaga's Issues

Best of... memory limit

Hi!
Thanks for your plugin!
In the "best of" page some reactions and the "best of all time" show a blank page and when I activate the debugger I see the following message:

Fatal error: Allowed memory size of 52428800 bytes exhausted (tried to allocate 32 bytes) in .../forum/library/database/class.dataset.php on line 144

What can I do?

I'm running Vanilla 2.1.6 and the latest version of your plugin from vanilla forum page (the one released november 2014). My php version is .4

Pager

The pager (more, less) doesn't display on my site. Also if I change the theme to the default one.
I'm using the last GitHub version with vanilla 2.1.6.

Best of all time page on my forum (the theme is bootstrap, but it doesn't work also with the default vanilla theme. I've also installed infinite scrolling plugin but it doesn't work also if I disable it):
http://www.spazioasperger.it/forum/best/alltime

Activating YAGA 0.1 wipes all source code

When activating YAGA under 2.1b2 the backend and the frontend appear to be white. A check in the source code tells me there is nod code anymore. I can't give more information it's really weird. If you need infophp insights just say so.

Avatar Cropped in Best Of...

Vanilla Version: 2.1.3

Comments: This could just be a theme issue, however it occurred on a couple different themes. Maybe this should be looked into.

Describe Issue: When you go to the "Best Of..." category, the thumbnail/avatar does not seem to scale to fit.
Screenshot(s):
image

Idea: Reaction Record List for Activities

On the activities page, I was thinking it would look great to have a reaction record list, like the one under discussion posts and comments, that shows avatars of users who clicked on a reaction. The reaction choices list could also be displayed without requiring a mouse hover as well if this were the case.

What do you all think?

Use new locale conventions

Notice  Locales in /applications/yaga/locale/de-DE/definitions.php is deprecated. Use /applications/yaga/locale/de-DE.php instead. in Z:\web\vanilla-master\library\core\class.locale.php line 253
Notice  Locales in /applications/yaga/locale/en-CA/definitions.php is deprecated. Use /applications/yaga/locale/en-CA.php instead. in Z:\web\vanilla-master\library\core\class.locale.php line 253
Notice  Locales in /applications/yaga/locale/pt-BR/definitions.php is deprecated. Use /applications/yaga/locale/pt-BR.php instead. in Z:\web\vanilla-master\library\core\class.locale.php line 253 

Edit Content Timeout Perk is broken.

From http://vanillaforums.org/discussion/30099/yagas-editcontenttimeout-perk-not-defaulting-to-default:

I ran into a problem after adding some ranks that stem from the fact that the EditContentTimeout perk option box does not default to "Default". The default option is actually 0, which is deny all editing. So for example, when the admin user earns a rank, yaga overrides Garden.EditContentTimeout and sets it to 0, even if that admin user is trying to set the original config option in the vanilla dashboard. The result is that Garden.EditContentTimeout can never be set to anything other than 0.

I just moved the "Default" option first before the rest of the options. This solved the problem.

--- library/functions.render.php
+++ library/functions.render.php
@@ -141,7 +141,7 @@
       );
     }
     // Add a default option
-    $Options = $Options + array('' => T('Default'));
+    $Options = array('' => T('Default')) + $Options;
      $Form = Gdn::Controller()->Form;
     $Fieldname = 'Conf' . $Config;

Check it out!

Reactions On Profile Overlap

Vanilla Version: 2.1.3

Describe Issue: When you go to a profile, if the reaction name is longer...it overlaps everything beside it.

Screenshot(s):
image

Update Installation documentation

Current documentation does not clarify how to enable a Garden application. Since most addons are plugins, this can cause some confusion.

Edit badges: Select reset bug in Firefox with Vanilla master

I don't know if you want to fix this (I would wait for 2.3), but just in case someone runs into this in the future:

Test in Firefox
http://jsfiddle.net/95r3uf91/4/

On blur the select changes back.
This happens on the edit badges screen when using Yaga with vanilla master and Firefox.

Happens in jQuery 1.9+ (where the attr() vs prop() change was), but it might as well be a browser bug.

changing

$(this).find("option[value='" + currentValue + "']").attr('selected', 'selected');

to

$(this).find("option[value='" + currentValue + "']")
  .attr('selected', 'selected')
  .prop('selected', true);

});

in admin.badges.css fixes it, but that shouldn't be necessary.

Suggestion: Make custom rules pluggable

What would you think about adding an event for custom rules in RulesController->GetRules() ?

A plugin could then include rule classes or maybe even add custom paths to look for rule classes with an event argument.

Badge settings screen is cluttered

A full badge set contains approximately 75 badges.

There should be an easy way to manage the large amount of duplicate badges.

Grouping by Rule Class is the current best idea.

No default transport file

I want there to be a high quality set of 'default' content.

Ideal 3 steps to a 'complete' gamification package:

  1. Upload yaga application
  2. Enable in dashboard
  3. Import default transport file

Needs sensible reactions, badges, and ranks.

Changing the icon for a badge doesn't update previous award Activities

At class.badgeawardmodel.php:83, the Activity is created with the following photo setting:

'Photo' => '/uploads/' . $Badge->Photo,

If the photo has not been set, this leads to missing images for activities. Even if you then set an image for the badge, the past activities are not updated to reflect the new image.

I think an update should be run against all activities with RecordID matching an updated badge. Presumably the same for badge name and description?

Deleting Actions always deletes associated reactions

There is no option to move associated reactions to another action ID when the action ID is deleted.

This would be helpful when merging a bunch of positive/negative actions into a simple thumbs up/down system.

This is extremely low priority.

Use vector images for reactions.

Use a font, or svg font for reactions. This would remove all the redundant images used in the administration backend.

For reference: #5

Fatal Error in YagaHooks.UserModel_AfterGetSession_Handler();

I just activated Yaga on a V2.1 install and run into this error when $Configuration['Debug'] = TRUE;
If it's FALSE the 3 menue points in the dashboard Reactions, Badges, Ranks do not appear and Yaga is not configurable. Bug or my failure? Thanx

yagahooks

Reactions are restricted

It is pretty difficult to get reactions on content that doesn't conform to standard Vanilla types.

I want to make it easy for custom types to accept reactions.

This will require rethinking the acted model and best controllers.

I am thinking something like:

echo Yaga::RenderReactionRecord($ID, $Type);
echo Yaga::RenderReactionList($ID, $Type);

This would allow plugins to put their own checks in terms of permissable requirements.

Will require an event in at least the reaction model.

Best Of Controller does not exist

The actions feature of Yaga increase/decrease the score of specific items. There should be a view that aggregates this data and displays it to the user.

Ideally, there will be filter options such as per category, per action, per user role, etc.

Point Recalculation

Not an issue, just leaving this here.

I saw that you had point recalculation as one of your plugin ideas:
https://github.com/hgtonight/Vanilla-Addons/blob/master/README.md

This is the query I have been using in the past:

update GDN_User u set u.Points =
(
  select sum(a.AwardValue) from GDN_Reaction r
  inner join GDN_Action a on r.ActionID = a.ActionID
  where u.UserID = r.ParentAuthorID
) + (
  select sum(b.AwardValue) from GDN_BadgeAward ba
  inner join GDN_Badge b on ba.BadgeID = b.BadgeID
  where u.UserID = ba.UserID
)        

Leaderboard includes banned users

In my opinion, the leaderboard should not included banned users.

--- modules/class.leaderboardmodule.php
+++ modules/class.leaderboardmodule.php
@@ -76,6 +76,7 @@
             ->Where('up.SlotType', $slot)
             ->Where('up.TimeSlot', gmdate('Y-m-d', Gdn_Statistics::TimeSlotStamp($slot)))
             ->Where('up.Source', 'Total')
+            ->Where('u.Banned', 0)
             ->OrderBy('up.Points', 'desc')
             ->Limit(C('Yaga.LeaderBoard.Limit', 10), 0)
             ->Get()

"Level 1" Rank Rewarded Twice

I'm using the default transport configuration. This seems to be present in 1.0.3 and with the current latest development code commits up to June 29, 2015.

When a new user joins or a user logs in for the first time since the application was enabled, they are rewarded the "Level 1" rank twice with two activities being posted saying they "earned a promotion to Level 1."

Could this be an issue with my configuration or a bug in the code?

Add a post reaction count rule

This is an idea submitted by a community member:

Track the amount of reactions garnered by a post. Once the targets for the post are hit, go ahead and reward the badge. For example:

  • Cool/Cooler/Coolest Post: Have a single post get X/2X/3X Awesome reactions.
  • Interesting/Interestinger/Interestingest Post: Have a single post get X/2X/3X Insightful reactions.
  • Weird/Weirder/Weirdest Post: Have a single post get X/2X/3X WTF reactions.
  • Funny/Funnier/Funniest Post: Have a single post get X/2X/3X LOL reactions.
  • Hysterical Post: Have a single post get X Awesome and X LOL reactions.
  • Fascinating Post: Have a single post get X Awesome and X Insightful reactions.
  • Mindblowing Post: Have a single post get X Awesome and X WTF reactions.
  • Clinical Post: Have a single post get X Insightful and X WTF reactions.
  • Witty Post: Have a single post get X Insightful and X LOL reactions.
  • Dark Post: Have a single post get X WTF and X LOL reactions.
  • Golden Post: Have a single post get X of every positive reaction.

The criteria form would just show all the actions available and allow users to enter a target for each one.

Sort the Badges

Allow re-ordering of the badges in the admin screen and front-end pages.

Orphan reaction records

When a post or discussion is deleted, the associated reaction records are not.
This leads to wrong reaction counts and trailing empty pages in profile/reactions.

AfterReactionSave event: No knowledge of previous reactions

The AfterReactionSave needs to pass the old (current) reaction for the same item if there is one.
The "Exists" EventArgument is not enough as it is true in both cases (new reaction added / existing reaction item updated).

When handling the event to increment/decrement the total reaction count per discussion I had to use a "hack" to get the current reaction:
https://github.com/bleistivt/YagaDiscussionReactionCount/blob/master/class.yagadiscussionreactioncount.plugin.php#L31

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.