Giter Club home page Giter Club logo

Comments (5)

hgrecco avatar hgrecco commented on May 18, 2024

The new test case shows that the bug is because MaskedArray (and not Quantity) is handling the multiplication. When the order of the operation is reversed, everything works as expected.

from pint.

canesin avatar canesin commented on May 18, 2024

It looses the masked behaviour.

from pint.

hgrecco avatar hgrecco commented on May 18, 2024

Multiplying meter by a masked array works as expected:

>>> from pint import UnitRegistry
>>> ureg = UnitRegistry()
>>> import numpy as np
>>> x = np.ma.masked_array([1, 2, 3], mask=[True, True, False])
>>> q = ureg.meter * x
>>> q
<Quantity([-- -- 3], 'meter')>
>>> q.magnitude
masked_array(data = [-- -- 3],
             mask = [ True  True False],
       fill_value = 999999)

Is the converse that is not working properly:

>>> q = x * ureg.meter
>>> q
masked_array(data = [-- -- <Quantity(3, 'meter')>],
             mask = [ True  True False],
       fill_value = 999999)

Can you confirm this in your system?

The problem is that the multiplication is always handled by the left operand. I think that the bug is that the ufunc is not honoring of the array_priority value. I am trying to confirm this with the numpy people.

from pint.

canesin avatar canesin commented on May 18, 2024

Yes, I can confirm that it works with multiplication by left. thanks.

from pint.

hgrecco avatar hgrecco commented on May 18, 2024

Review once that #905 is implemented

from pint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.