heyarne / airsonic-ui Goto Github PK

This concerns the keyboard shortcuts as well as the previous / next buttons in the player. It should instead stay paused. Clicking a track in one of the playlist UIs should still start playback as it does now.

The devDependency shadow-cljs was updated from 2.8.40 to 2.8.41.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I think it makes sense to handle scrobbling completely on the clientside. I created a branch feature/lastfm to track progress on this. The lastfm API is a a bit ugly but it should work. The main reason is that server-side development takes some time and the new rest API will have to be planned carefully.

It still makes sense to leave some logic related to artist information etc. on the server. The good news is that you don't need any authorization for that (see album.getInfo, artist.getInfo and artist.getSimilar). It should be easier to do this scrobbling on the client though, so maybe we can fix airsonic/airsonic#776 and finally close quite a popular issue.

The devDependency shadow-cljs was updated from 2.8.83 to 2.8.84.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency shadow-cljs was updated from 2.8.78 to 2.8.79.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency sass was updated from 1.22.5 to 1.22.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sass is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency shadow-cljs was updated from 2.9.4 to 2.9.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This issue is meant to list things that would be nice to have but aren't really possible with the current @airsonic api.

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency shadow-cljs was updated from 2.8.99 to 2.8.100.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Before implementing sharing, playlists etc, we should take user roles into consideration. My idea would be to use http://www.subsonic.org/pages/api.jsp#getUser for authenticating on login and saving the roles locally.

The devDependency shadow-cljs was updated from 2.8.49 to 2.8.50.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

When logged in, on the landing page, I can only see 5 albums, while on the old interface it's almost two times more.

The devDependency sass was updated from 1.23.2 to 1.23.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sass is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I was testing it out and so far I must say its amazing. One thing I noticed missing is a volume bar.

Auto-login currently always redirects to /hello instead of checking window.location.hash.

The main issue here is that we page through content that is loaded once; also the number of pages doesn't really match up.

A better approach would...

• ...load results from per-page * (page - 1) to per-page * (page - 1) + 5 * per-page. This way we always should be able to page through the results quickly
• ...concatenate all responses in a subscription

Since shadow-cljs supports hot-reloading stylesheets from relative paths now we can probably simplify the build scripts a bit. See https://github.com/thheller/shadow-cljs/releases/tag/2.4.21

The devDependency shadow-cljs was updated from 2.8.71 to 2.8.72.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shadow-cljs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

They should just take the standard credential map containing user, password and server and pull out their info as required.

Even though the server is persisted, the first api request receives nil when you hit the reload button.

This should use re-pressed now that it doesn't depend on jQuery anymore. For now we just port over the old keyboard shortcuts, keeping it simple.

This is annoying especially with longer tracks on slower connections.

Should roughly look like this:

{:queue [{...}, {... :current? true}, ...]
 :shuffle? true ;; or false
 :repeat :all} ;; or :current / :none

At the moment we're looking at the content and trying to figure out which page we're looking at. Idk why it was implemented like that in the first place.

It would be nice to go back to the main page by clicking the logo on the top left.

This leads to a build that's approximately 200kb larger / 100kb gzipped. See the attached build reports (generated via npx shadow-cljs run shadow.cljs.build-report app build-report.html):

build-reports.zip

Awesome that somebody is finally modernizing the Airsonic UI. Kudos to you Arne!

Have you considered a column browser?
Something like this (see attached pic - based on MM4 browser) would be awesome in my POV.

It should read locations/nodes for the tree, tags for the genre/artist/album (and more), files for the tracks window below with user set choice of columns showing tags for files. Users should even be allowed to resize the different parts as they please.

I guess its mostly useful for people with large collections or a wide variation of tags.

To reproduce:

1. Login
2. Open some link in the app, for example an album
3. Copy the url
4. Paste it into a new tab

Behavior:
Before being redirected you can briefly see the login form after the loading spinner.

Expected behavior:
The loading spinner should be the only thing we see.

Hi,

When trying to play audio through the UI in Safari, I get this error:

Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.

This is most probably caused by the recent change in policy regarding audio autoplay in Safari (11 and 12):
https://www.reddit.com/r/webdev/comments/71nkym/safari_11_has_a_major_change_to_web_audio_api/
https://webkit.org/blog/7734/auto-play-policy-changes-for-macos/

Clicking on a track in queue to start playing it manually doesn't work either.

Thanks for the hard work! Airsonic-UI looks great :-)

This is only a minor issue. Still the progress bar don't shrink after changing the windows size.

Currently the response a request overwrites the previous one, which is a bit bogus. We should allow multiple requests at once. This should work together nicely with the events fired for a route:

This is a requirement for #19.