hexagenic / wanikaniwallpaper Goto Github PK

Should take named paramters in typical unix style.
eg:
wanikaniwallaper --key my-key --resolution 1920x1080

The v2 API is not yet finalized, so it does not make sense to drop support for the v1 API right now, but support for the new version should be considered.

I'll gladly give an implementation with the current v2 API a try.

Should be possible to set colors for background and SRS-levels through config files and command line options.

Hi,

WaniKani kanji progress page contains 2027 characters and your order file which is 5 years old contains 2044 characters. I haven't read in detail your code. Sorry, haven't got enough time. Just wanted to let you know about potential problem. It's worth to have some reliable and up to date method of ordering which will display only WK kanji and exactly all of them.

Regards,
mrowqa

Fonts are currendly hard-coded as an absolute path.

• Research posibility to get list of system fonts (needs to work on linux, windows and mac)
• If nothing is found, let font be configurable from config file/command line

I had some trouble building the project on Fedora 38, it would be good to mention where to get the dependencies on non Debian systems.

dnf install freetype-devel jsoncpp-devel boost-devel cmake make takes care of most things, but utfcpp does not seem to be packaged for fedora at least. There is a tumbleweed rpm package, but I could not get that to work.

Besides that, maybe add cmake . && cmake --build . to the readme.

You don't validate the loading of the file order in order.cpp.
This results in an std::bad_alloc exception when order does not exist or isn't readable. Please validate the loading process and print a pretty error message when it fails :)

Use windows/posix API to locate fonts installed on the system

Makes building and maintaining windows build easier.

Should be possible to override with curl/openssl through cmake flags.

Make it easier to maintain across platforms.

• Find an OSX-developer
• Ask for his help.

Usage documentation in three forms:

• --help command
• man-page
• README

Hey,

I'm using your program to generate my current progress on daily basis as one of my few wallpapers. It's great! Thank you.
Today I've got an idea: it would be cool to have somehow marked (highlight, border) these kanji which changed lately. Haven't checked the API, maybe it allow you get last time given kanji changed SRS level to Apprentice, Guru and so on*. If not, you can keep progress info in SQLite db or some text file. Then you can add a parameter as "latest changes threshold" with default value as a week or something (remember there aren't so many reviews of kanji, most of them are vocabs).
* worth giving further thought if it should differentiate Apprentice 1-4 and Guru 1-2 levels. Maybe set it as an option?

Regards,
mrowqa

Hey,

after playing for a while with your program, I really suggest adding two pieces of information to README:

• Mentioning that order file is important and explaining how it works. If it is not meant to be changed by user - compiling it into binary to have no dependency on it.
• Mentioning that people can use config.ini, explaining how to use it, and even providing some config.ini.template or config.ini.example with the sources and all options. That's a cool feature, so why hiding it?

Regards,
mrowqa

Please define PNG_SKIP_SETJMP_CHECK before including png.h for us beloved debian user

The WK api doesn't work via http anymore and returns a 302 code redirecting to its https version. A 302 response is a vaild answer and curl doesn't throw an error but instead returns an empty string instead which libjson can't parse.
Simply using https instead fixes this error.

Hi. I love this app. I think I found a minor bug. If I execute the binary from outside the directory where it and the files order and config.ini are located, it says it can't find them, while executing the binary from its directory works perfect. I think the binary only searches for files in the user's cwd rather than on the directory it is located.

C++ now has built-in libraries for unicode conversion, use those instead.

I'm getting a segmentation fault at renderer.cpp:73
No idea how you are handling all the rendering stuff so I didn't play around there to not make things worse.

Project needs to be set up for compilation under Visual Studio.