heuer / qrcode-artistic Goto Github PK

qrcode-artistic depends on segno and Pillow, but they aren’t listed in the setup.cfg.

I.e. use dark / light instead of color / background

With the main module i can do something like this:

buff = io.BytesIO()
segno.make_qr("Some input").save(buff, kind="png", border=1, scale=10)
buff.getvalue()

Is there a way to do that also with artistic qr-codes?

See heuer/segno#28

Hi! I think there's an infinite loop in to_artistic() when scale is a float. Example:

>>> qr.to_artistic(background='whatever.png', target='qr.png', scale=4.5)
^CTraceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../.direnv/python-3.10.4/lib/python3.10/site-packages/qrcode_artistic.py", line 134, in write_artistic
    while scale % 3:
KeyboardInterrupt

I'm using qrcode-artistic==2.1.0, segno==1.5.2

I think this is happening here:
https://github.com/heuer/qrcode-artistic/blob/b93c548/qrcode_artistic.py#L140-L141

as you can see, this loops forever with any non-integer

>>> x = 4.5
>>> for i in range(20):
...  print(x % 3)
...  x += 1
... 
1.5
2.5
0.5
1.5
2.5
0.5

is it reasonable to add a check before the loop which crashes if round(scale) != scale? I'm happy to submit this PR if that's useful to you.

thanks for this library, I love the results

There is a white space outside of QR codes. Although it is possible to trim it using other libraries, I think it would be great to have this option in this library.
Before:

After:

See heuer/segno#86

See https://segno.readthedocs.io/en/stable/serializers.html#more-colorful-qr-codes

Hello,

When I create a QR code pointing to https://en.wikipedia.org/wiki/Main_Page with the scale set to 35 and with an image background using qrcode_artistic, the resulting QR image is very blurry even if the provided image is large.
If I use segno alone to create a simple QR, the resulting image is crisp.

This is the code:

image = 'firefoxLogo.png' qr = segno.make('https://en.wikipedia.org/wiki/Main_Page', micro=False) qrSimple = qr.save('outSimple.png', scale=35, border=1) qrArtistic = qr.to_artistic(background=image, border=1, target='outArtistic.png', scale=35)

Simple QR:

Artistic QR

And the logo file I have used:

In order to avoid scaling issues altogether (see #4), it would be great if vector images could be used as a backdrop (see https://en.wikipedia.org/wiki/File:Firefox_logo,_2019.svg).