herotc / hero-rotation Goto Github PK

Updated to the latest version with Twitch - upon logging into the game I get the error 1x AethysRotation\Main.lua:145: Usage: AethysRotation_MainFrame:SetPoint("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY])
full error text
1x AethysRotation\Main.lua:145: Usage: AethysRotation_MainFrame:SetPoint("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY])
[C]: in function `SetPoint'
AethysRotation\Main.lua:145: in function <AethysRotation\Main.lua:131>

Locals:
(*temporary) = AethysRotation_MainFrame {
0 =
Lock = defined @AethysRotation\Main.lua:95
ResizeButtons = defined @AethysRotation\Main.lua:60
Unlock = defined @AethysRotation\Main.lua:79
ResizeUI = defined @AethysRotation\Main.lua:38
}
(*temporary) = nil
(*temporary) = UIParent {
0 =
firstTimeLoaded = 1
}
(*temporary) = nil
(*temporary) = nil

Using any /aer command results in further errors. /aer unlock gives 1x AethysRotation\UI.lua:155: attempt to get length of field 'Part' (a nil value)
full error text
1x AethysRotation\UI.lua:155: attempt to get length of field 'Part' (a nil value)
AethysRotation\UI.lua:155: in function HideParts' AethysRotation\UI.lua:40: in function ResetIcons'
AethysRotation\Main.lua:81: in function Unlock' AethysRotation\Core.lua:153: in function ?'
FrameXML\ChatFrame.lua:4512: in function <FrameXML\ChatFrame.lua:4459>
[C]: in function ChatEdit_ParseText' FrameXML\ChatFrame.lua:4180: in function ChatEdit_SendText'
FrameXML\ChatFrame.lua:4216: in function `ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals:
self = AethysRotation_MainIconFrame {
ChangeIcon = defined @AethysRotation\UI.lua:108
Init = defined @AethysRotation\UI.lua:92
CooldownFrame = AethysRotation_MainIconCooldownFrame {
}
SetCooldown = defined @AethysRotation\UI.lua:115
SetupParts = defined @AethysRotation\UI.lua:136
InitParts = defined @AethysRotation\UI.lua:118
TempTexture = {
}
HideParts = defined @AethysRotation\UI.lua:154
0 =
texture = {
}
}
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to get length of field 'Part' (a nil value)"

/aer toggle gives 1x AethysRotation\UI.lua:449: attempt to index field 'Button' (a nil value)
full error text
1x AethysRotation\UI.lua:449: attempt to index field 'Button' (a nil value)
AethysRotation\UI.lua:449: in function UpdateButtonText' AethysRotation\Core.lua:150: in function ?'
FrameXML\ChatFrame.lua:4512: in function <FrameXML\ChatFrame.lua:4459>
[C]: in function ChatEdit_ParseText' FrameXML\ChatFrame.lua:4180: in function ChatEdit_SendText'
FrameXML\ChatFrame.lua:4216: in function `ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals:
self = AethysRotation_ToggleIconFrame {
0 =
UpdateButtonText = defined @AethysRotation\UI.lua:447
Init = defined @AethysRotation\UI.lua:318
ResetAnchor = defined @AethysRotation\UI.lua:372
AddButton = defined @AethysRotation\UI.lua:377
}
i = 3
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'Button' (a nil value)"

As mentioned on Discord the window close sound is popping up all the time when ppl leave or join the group. You mentioned something about the Artifact Scan and that I should open a ticket. Here you go. ;)

Is there any way to add check boxes for the option Sindragosa's Fury OffGDC?

When the APL was updated a few weeks ago, a Vanish condition was added to the Sub DfA conditionals. This causes problems with DfA usage with the cooldown button disabled as Vanish is not used and thus DfA will never be suggested even when appropriate.

The "or not S.Vanish:CooldownUp()" conditional in the DfA line should be altered to consider AR.CDsON()

As an additional note about this conditional in general:

Given the relatively small gain of this Vanish conditional in optimal play (very, very small gain, even at high iterations--need to be at 0.03% error to see a difference within the margin of error,) it may be worth considering removing this Vanish conditional for AER.

Even missing a single Vanish macro GCD can result in DfA being delayed very significantly, which is not a problem sims have (as they flawlessly execute Vanish sequences) but is definitely likely when players are having to react to suggestions quickly. I'm also not sure this is a gain at all without the Shoulders--simming at 54k iterations with my character without shoulders, removing "!talent.dark_shadow.enabled|!cooldown.vanish.up" both profiles are still within the margin of error.

With the T20M DfA profiles, there is still no difference at 0.05% and at 65k iterations actually seemed to show a 2k DPS loss over the altered APL with a DPS error of 410. So I think this conditional in general may need re-evaluation.

Regarding AER specifically: since the Vanish macro only shows up in very specific conditions, it's relatively easy to accidentally skip and then not see DfA suggested for a full cycle--almost certainly a larger DPS loss than not having the conditional, but SimC likely never encounters this condition.

Simming with a special conditional, it appears that even one mistaken Vanish GCD skip is worth about an 8k DPS loss for my character, which seems like really poor risk/reward ratio (considering the conditional has no gain for me anyway!)

Edit: I see you've addressed this on the addon page.

(Apologies if this is more info than needed, but I wasn't sure if I should submit all of them or just one)

1

1x AethysRotation\Panels.lua:8: attempt to index field 'GUI' (a nil value)
AethysRotation\Panels.lua:8: in main chunk

Locals:
addonName = "AethysRotation"
AR = <table> {
}
AC = <table> {
 RegisterForEvent = <function> defined @AethysCore\Events\Main.lua:46
 MAXIMUM = 40
 RegisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:77
 BuildInfo = <table> {
 }
 Unit = <table> {
 }
 MythicDungeon = <function> defined @AethysCore\Class\Player.lua:1084
 Item = <table> {
 }
 LiveRealm = <function> defined @AethysCore\Core.lua:32
 GetTime = <function> defined @AethysCore\Core.lua:45
 BetaRealm = <function> defined @AethysCore\Core.lua:40
 Spell = <table> {
 }
 HasTier = <function> defined @AethysCore\Class\Player.lua:1036
 GetInstanceInfo = <function> defined @AethysCore\Misc\ToSort.lua:31
 RegisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:122
 MainFrame = AethysCore_MainFrame {
 }
 Equipment = <table> {
 }
 RecoveryTimer = <function> defined @AethysCore\Misc\ToSort.lua:74
 Enum = <table> {
 }
 CompareThis = <function> defined @AethysCore\Core.lua:74
 Latency = <function> defined @AethysCore\Misc\ToSort.lua:68
 LastUnitCycled = <table> {
 }
 Pulse = <function> defined @AethysCore\Main.lua:29
 UnitNotInFrontTime = 0
 OutOfCombatTime = <function> defined @AethysCore\Misc\ToSort.lua:89
 LastUnitCycledTime = 0
 Class = <function> defined @AethysCore\Class\Main.lua:19
 Print = <function> defined @AethysCore\Core.lua:54
 UnitNotInFront = <table> {
 }
 TTD = <table> {
 }
 CombatEnded = 1
 CombatStarted = 0
 GetInstanceDifficulty = <function> defined @AethysCore\Misc\ToSort.lua:62
 CombatTime = <function> defined @AethysCore\Misc\ToSort.lua:84
 UnregisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:196
 GetEquipment = <function> defined @AethysCore\Class\Player.lua:962
 BMPullTime = <function> defined @AethysCore\Misc\ToSort.lua:94
 UnregisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:154
 UnregisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:168
 TTDRefresh = <function> defined @AethysCore\Class\Unit.lua:840
 RecoveryOffset = <function> defined @AethysCore\Misc\ToSort.lua:79
 UnregisterForPetCombatEvent = <function> defined @AethysCore\Events\Main.lua:182
 UnregisterForEvent = <function> defined @AethysCore\Events\Main.lua:137
 SpecID_ClassesSpecs = <table> {
 }
 RegisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:107
 RegisterForPetCombatEvent = <function> defined @AethysCore\Events\Main.lua:92
 RegisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:62
 GetEnemies = <function> defined @AethysCore\Misc\Enemies.lua:23
 UnregisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:210
 Timer = <table> {
 }
 MergeTable = <function> defined @AethysCore\Core.lua:59
 PTRRealm = <function> defined @AethysCore\Core.lua:36
 GUISettings = <table> {
 }
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'GUI' (a nil value)"

2

1x AethysRotation\Settings-Settings.lua:9: attempt to index local 'GUI' (a nil value)
AethysRotation\Settings-Settings.lua:9: in main chunk

Locals:
addonName = "AethysRotation"
AR = <table> {
}
AC = <table> {
 RegisterForEvent = <function> defined @AethysCore\Events\Main.lua:46
 MAXIMUM = 40
 RegisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:77
 BuildInfo = <table> {
 }
 Unit = <table> {
 }
 MythicDungeon = <function> defined @AethysCore\Class\Player.lua:1084
 Item = <table> {
 }
 LiveRealm = <function> defined @AethysCore\Core.lua:32
 GetTime = <function> defined @AethysCore\Core.lua:45
 BetaRealm = <function> defined @AethysCore\Core.lua:40
 Spell = <table> {
 }
 HasTier = <function> defined @AethysCore\Class\Player.lua:1036
 GetInstanceInfo = <function> defined @AethysCore\Misc\ToSort.lua:31
 RegisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:122
 MainFrame = AethysCore_MainFrame {
 }
 Equipment = <table> {
 }
 RecoveryTimer = <function> defined @AethysCore\Misc\ToSort.lua:74
 Enum = <table> {
 }
 CompareThis = <function> defined @AethysCore\Core.lua:74
 Latency = <function> defined @AethysCore\Misc\ToSort.lua:68
 LastUnitCycled = <table> {
 }
 Pulse = <function> defined @AethysCore\Main.lua:29
 UnitNotInFrontTime = 0
 OutOfCombatTime = <function> defined @AethysCore\Misc\ToSort.lua:89
 LastUnitCycledTime = 0
 Class = <function> defined @AethysCore\Class\Main.lua:19
 Print = <function> defined @AethysCore\Core.lua:54
 UnitNotInFront = <table> {
 }
 TTD = <table> {
 }
 CombatEnded = 1
 CombatStarted = 0
 GetInstanceDifficulty = <function> defined @AethysCore\Misc\ToSort.lua:62
 CombatTime = <function> defined @AethysCore\Misc\ToSort.lua:84
 UnregisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:196
 GetEquipment = <function> defined @AethysCore\Class\Player.lua:962
 BMPullTime = <function> defined @AethysCore\Misc\ToSort.lua:94
 UnregisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:154
 UnregisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:168
 TTDRefresh = <function> defined @AethysCore\Class\Unit.lua:840
 RecoveryOffset = <function> defined @AethysCore\Misc\ToSort.lua:79
 UnregisterForPetCombatEvent = <function> defined @AethysCore\Events\Main.lua:182
 UnregisterForEvent = <function> defined @AethysCore\Events\Main.lua:137
 SpecID_ClassesSpecs = <table> {
 }
 RegisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:107
 RegisterForPetCombatEvent = <function> defined @AethysCore\Events\Main.lua:92
 RegisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:62
 GetEnemies = <function> defined @AethysCore\Misc\Enemies.lua:23
 UnregisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:210
 Timer = <table> {
 }
 MergeTable = <function> defined @AethysCore\Core.lua:59
 PTRRealm = <function> defined @AethysCore\Core.lua:36
 GUISettings = <table> {
 }
}
GUI = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'GUI' (a nil value)"

3

1x AethysRotation\Commons.lua:18: attempt to index field 'GUISettings' (a nil value)
AethysRotation\Commons.lua:18: in main chunk

Locals:
addonName = "AethysRotation"
AR = <table> {
 CastLeftOffset = 1
 MaxQueuedCasts = 3
 CmdHandler = <function> defined @AethysRotation\Core.lua:138
 Print = <function> defined @AethysRotation\Core.lua:31
 CastQueue = <function> defined @AethysRotation\Core.lua:91
 Cast = <function> defined @AethysRotation\Core.lua:72
 Locked = <function> defined @AethysRotation\Core.lua:224
 CastLeftCommon = <function> defined @AethysRotation\Core.lua:106
 CastSuggested = <function> defined @AethysRotation\Core.lua:126
 APLs = <table> {
 }
 SetAPL = <function> defined @AethysRotation\Core.lua:37
 Commons = <table> {
 }
 CastLeftNameplate = <function> defined @AethysRotation\Core.lua:117
 CastSuggestedOffset = 1
 CastLeft = <function> defined @AethysRotation\Core.lua:111
 AoEON = <function> defined @AethysRotation\Core.lua:214
 CastOffGCDOffset = 1
 CDsON = <function> defined @AethysRotation\Core.lua:209
 ON = <function> defined @AethysRotation\Core.lua:219
 GetTexture = <function> defined @AethysRotation\Core.lua:42
}
AC = <table> {
 RegisterForEvent = <function> defined @AethysCore\Events\Main.lua:46
 MAXIMUM = 40
 RegisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:77
 BuildInfo = <table> {
 }
 Unit = <table> {
 }
 MythicDungeon = <function> defined @AethysCore\Class\Player.lua:1084
 Item = <table> {
 }
 LiveRealm = <function> defined @AethysCore\Core.lua:32
 GetTime = <function> defined @AethysCore\Core.lua:45
 BetaRealm = <function> defined @AethysCore\Core.lua:40
 Spell = <table> {
 }
 HasTier = <function> defined @AethysCore\Class\Player.lua:1036
 GetInstanceInfo = <function> defined @AethysCore\Misc\ToSort.lua:31
 RegisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:122
 MainFrame = AethysCore_MainFrame {
 }
 Equipment = <table> {
 }
 RecoveryTimer = <function> defined @AethysCore\Misc\ToSort.lua:74
 Enum = <table> {
 }
 CompareThis = <function> defined @AethysCore\Core.lua:74
 Latency = <function> defined @AethysCore\Misc\ToSort.lua:68
 LastUnitCycled = <table> {
 }
 Pulse = <function> defined @AethysCore\Main.lua:29
 UnitNotInFrontTime = 0
 OutOfCombatTime = <function> defined @AethysCore\Misc\ToSort.lua:89
 LastUnitCycledTime = 0
 Class = <function> defined @AethysCore\Class\Main.lua:19
 Print = <function> defined @AethysCore\Core.lua:54
 UnitNotInFront = <table> {
 }
 TTD = <table> {
 }
 CombatEnded = 1
 CombatStarted = 0
 GetInstanceDifficulty = <function> defined @AethysCore\Misc\ToSort.lua:62
 CombatTime = <function> defined @AethysCore\Misc\ToSort.lua:84
 UnregisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:196
 GetEquipment = <function> defined @AethysCore\Class\Player.lua:962
 BMPullTime = <function> defined @AethysCore\Misc\ToSort.lua:94
 UnregisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:154
 UnregisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:168
 TTDRefresh = <function> defined @AethysCore\Class\Unit.lua:840
 RecoveryOffset = <function> defined @AethysCore\Misc\ToSort.lua:79
 UnregisterForPetCombatEvent = <function> defined @AethysCore\Events\Main.lua:182
 UnregisterForEvent = <function> defined @AethysCore\Events\Main.lua:137
 SpecID_ClassesSpecs = <table> {
 }
 RegisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:107
 RegisterForPetCombatEvent = <function> defined @Int

4

1x AethysRotation\Main.lua:31: attempt to index field 'GUISettings' (a nil value)
AethysRotation\Main.lua:31: in main chunk

Locals:
addonName = "AethysRotation"
AR = <table> {
 CastLeftOffset = 1
 NameplateIconFrame = AethysRotation_NameplateIconFrame {
 }
 ToggleIconFrame = AethysRotation_ToggleIconFrame {
 }
 MaxQueuedCasts = 3
 CmdHandler = <function> defined @AethysRotation\Core.lua:138
 Print = <function> defined @AethysRotation\Core.lua:31
 CastQueue = <function> defined @AethysRotation\Core.lua:91
 Cast = <function> defined @AethysRotation\Core.lua:72
 Commons = <table> {
 }
 Nameplate = <table> {
 }
 Locked = <function> defined @AethysRotation\Core.lua:224
 CreateBackdrop = <function> defined @AethysRotation\UI.lua:57
 CastLeftCommon = <function> defined @AethysRotation\Core.lua:106
 CastSuggested = <function> defined @AethysRotation\Core.lua:126
 APLs = <table> {
 }
 ResetIcons = <function> defined @AethysRotation\UI.lua:36
 SuggestedIconFrame = AethysRotation_SuggestedIconFrame {
 }
 CastLeftNameplate = <function> defined @AethysRotation\Core.lua:117
 SetAPL = <function> defined @AethysRotation\Core.lua:37
 SmallIconFrame = AethysRotation_SmallIconFrame {
 }
 LeftIconFrame = AethysRotation_LeftIconFrame {
 }
 MainFrame = AethysRotation_MainFrame {
 }
 MainIconFrame = AethysRotation_MainIconFrame {
 }
 CastSuggestedOffset = 1
 CastLeft = <function> defined @AethysRotation\Core.lua:111
 AoEON = <function> defined @AethysRotation\Core.lua:214
 CastOffGCDOffset = 1
 CDsON = <function> defined @AethysRotation\Core.lua:209
 ON = <function> defined @AethysRotation\Core.lua:219
 GetTexture = <function> defined @AethysRotation\Core.lua:42
}
AC = <table> {
 RegisterForEvent = <function> defined @AethysCore\Events\Main.lua:46
 MAXIMUM = 40
 RegisterForSelfCombatEvent = <function> defined @AethysCore\Events\Main.lua:77
 BuildInfo = <table> {
 }
 Unit = <table> {
 }
 MythicDungeon = <function> defined @AethysCore\Class\Player.lua:1084
 Item = <table> {
 }
 LiveRealm = <function> defined @AethysCore\Core.lua:32
 GetTime = <function> defined @AethysCore\Core.lua:45
 BetaRealm = <function> defined @AethysCore\Core.lua:40
 Spell = <table> {
 }
 HasTier = <function> defined @AethysCore\Class\Player.lua:1036
 GetInstanceInfo = <function> defined @AethysCore\Misc\ToSort.lua:31
 RegisterForCombatSuffixEvent = <function> defined @AethysCore\Events\Main.lua:122
 MainFrame = AethysCore_MainFrame {
 }
 Equipment = <table> {
 }
 RecoveryTimer = <function> defined @AethysCore\Misc\ToSort.lua:74
 Enum = <table> {
 }
 CompareThis = <function> defined @AethysCore\Core.lua:74
 Latency = <function> defined @AethysCore\Misc\ToSort.lua:68
 LastUnitCycled = <table> {
 }
 Pulse = <function> defined @AethysCore\Main.lua:29
 UnitNotInFrontTime = 0
 OutOfCombatTime = <function> defined @AethysCore\Misc\ToSort.lua:89
 LastUnitCycledTime = 0
 Class = <function> defined @AethysCore\Class\Main.lua:19
 Print = <function> defined @AethysCore\Core.lua:54
 UnitNotInFront = <table> {
 }
 TTD = <table> {
 }
 CombatEnded = 1
 CombatStarted = 0
 GetInstanceDifficulty = <function> defined @AethysCore\Misc\ToSort.lua:62
 CombatTime = <function> defined @AethysCore\Misc\ToSort.lua:84
 UnregisterForCombatPrefixEvent = <function> defined @AethysCore\Events\Main.lua:196
 GetEquipment = <function> defined @AethysCore\Class\Player.lua:962
 BMPullTime = <function> defined @AethysCore\Misc\ToSort.lua:94
 UnregisterForCombatEvent = <function> defined @AethysCore\Events\Main.lua:154
 UnregisterForSelfCombatEvent = <function> defined @AethysCore\Events

I'm using Aethys over top of a set of WeakAuras. On default settings, the icon is under the set of WAs. If I go into settings and move the Aethys icon to "HIGH" strata, then reload, it remains below the set of WAs. I have confirmed that the SavedVariables then shows AethysRotationDB.GUISettings.General.MainFrameStrata is set to "HIGH". If I then edit Interface\Addons\AethysRotation\Settings.lua and set the default settings to use a MainFrameStrata of "HIGH", the Aeythis icon is layered properly and shows on top of the WAs.

I can't actually figure how to move the frame. It's attached to background if it matters, any help would be much appreciated.

Cheers!

Auto-hide the main frame when on a spec or class that is not currently supported.

The event handler for OnSpecGearTalentUpdate / Player Inspector triggers on PLAYER_EQUIPMENT_CHANGED and ZONE_CHANGED_NEW_AREA, which in turn calls Spell:ArtifactScan();

This ends up calling SocketInventoryItem(INVSLOT_MAINHAND) which hides the character panel automatically in the Blizzard UI.

Once these events are registered, the character panel will disappear every time the player swaps gear in the panel, or whenever changing zones.

Hi there. I love this addon, but the frame is located right in the middle of the screen, and I wasn't able to move it. How could it be done?

Thanks in advance for your time!

The rogue / subtlety rotation never seems to suggest death from above if you are talented into it.

Would be useful to know what you will be using after pooling, for example Vanish+SS, or Shadow Dance+SS, etc.

LUA error with the dropdown in the settings. Previously discussed on Discord.

AN example of errors :
2x [ADDON_ACTION_BLOCKED] AddOn 'AethysRotation_Rogue' tried to call the protected function 'CompactPartyFrame:unusedFunc()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function unusedFunc' ...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:160: in function CompactRaidFrameContainer_LayoutFrames'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:130: in function CompactRaidFrameContainer_TryUpdate' ...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:57: in function CompactRaidFrameContainer_OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>

Locals:
InCombatSkipped

Krich on discord :
I talked with one guy at wowui channel on irc
And seems like every addon that adds a dropdown menu on the esc-interface panel taints the ui If you access the settings in combat
I tested with Hekili and voila, error message
And it always taints compactraidframe
Yeah, some guy confirmed it to me
Apparently , frames can't be created or destroyed in the secure enviroment while in combat, so once you try to create the actual drop down, it taints, then any call made after that taints as well
because a dropdown works by creating a new frame when the drop down shows, it can't do that in combat without tainting
Solutions... Create our own lib, or using WoWAce library which cares about those stuff
Well we only need to create a lib and use functions from
EasyMenu.lua, UIDropDownMenu.lua and UIDropDownMenuTemplates.xml
Frames , tables and variables
And renamed everything
There was a guy who Apparently works for blizzard and linked me this
http://www.wowinterface.com/downloads/info22630-NoTaintUIDropDownMenu.html

Message: ...erface\AddOns\AethysRotation_Hunter\BeastMastery.lua:198: attempt to compare nil with number
Time: 07/19/17 06:29:12
Count: 151
Stack: ...erface\AddOns\AethysRotation_Hunter\BeastMastery.lua:198: attempt to compare nil with numberInterface\SharedXML\SharedBasicControls.lua:189: in function <Interface\SharedXML\SharedBasicControls.lua:187>
Interface\SharedXML\SharedBasicControls.lua:204: in function <Interface\SharedXML\SharedBasicControls.lua:203>
[C]: ?
...erface\AddOns\AethysRotation_Hunter\BeastMastery.lua:198: in function `?'
Interface\AddOns\AethysRotation\Main.lua:292: in function <Interface\AddOns\AethysRotation\Main.lua:282>

Locals: errorTypeCVar = "scriptErrors"
warnType = false
msg = "...erface\AddOns\AethysRotation_Hunter\BeastMastery.lua:198: attempt to compare nil with number"
messageType = 0
hideErrorFrame = false
IsErrorCVarEnabled = defined @interface\SharedXML\SharedBasicControls.lua:183

If AethysRotation is enabled, i can't join random bgs. I click the button but nothing happens. I tested it by enabled all other Addons but AethysRotation, so I can say for sure that this Addon has a little bug.

I like this Addon, please fix it :D

-Greets

AR.MainIconFrame:InitParts and AR.MainIconFrame:SetupParts use non-modified values of 64px and therefore are always full size regardless of AethysRotationDB.ScaleUI.

Hi !
It's not an issue, but in frost, some KM proc is used on Obliterate instead of Frostscythe (if you've got the talent).

And if you've got the talent Frostscythe, you must use KM proc on it even on single target.

I hope I was clear enough, if not, feel free to ask me.

P.S : Sorry for my bad english :)

Could icons be greyed out icons when out of range rather than no icons at all?

'Mind Freeze' is not showing up when interruptable spell is being cast.

x [ADDON_ACTION_BLOCKED] AddOn 'AethysRotation_Rogue' tried to call the protected function ':Hide()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function Hide' FrameXML\WorldMapActionButton.lua:58: in function Clear'
FrameXML\WorldMapActionButton.lua:67: in function Refresh' FrameXML\WorldMapActionButton.lua:19: in function SetMapAreaID'
FrameXML\WorldMapFrame.lua:1341: in function WorldMapFrame_Update' FrameXML\WorldMapFrame.lua:2873: in function WorldMapFrame_UpdateMap'
FrameXML\WorldMapFrame.lua:451: in function <FrameXML\WorldMapFrame.lua:435>
[C]: ?
[C]: in function SetMapToCurrentZone' FrameXML\WorldMapFrame.lua:381: in function <FrameXML\WorldMapFrame.lua:360> [C]: in function Show'
FrameXML\UIParent.lua:2421: in function SetUIPanel' FrameXML\UIParent.lua:2223: in function ShowUIPanel'
FrameXML\UIParent.lua:2133: in function <FrameXML\UIParent.lua:2129>
[C]: in function SetAttribute' FrameXML\UIParent.lua:2915: in function ShowUIPanel'
FrameXML\UIParent.lua:2899: in function ToggleFrame' FrameXML\WorldMapFrame.lua:263: in function <FrameXML\WorldMapFrame.lua:235> [C]: in function ToggleWorldMap'
[string "TOGGLEWORLDMAP"]:1: in function <[string "TOGGLEWORLDMAP"]:1>

Locals:

Date: 2017-10-29 11:09:07
ID: 1
Error occured in: Global
Count: 1
Message: ...erface\AddOns\AethysRotation_Warlock\Destruction.lua line 332:
attempt to call method 'BuffRemainsP' (a nil value)
Debug:
...erface\AddOns\AethysRotation_Warlock\Destruction.lua:332: ?()
AethysRotation\Main.lua:332:
AethysRotation\Main.lua:322
Locals:
(*temporary) = nil
(*temporary) =

Instead of no icon displayed

Hi, i see you addon is not supported Druid Feral rotation now, but you can activate him rotation in testing mode ? :)

Ty for working this beautiful addons your job is awesome!

The artifact spell of balance is New Moon which cycle between NewMoon > HalfMoon > FullMoon > NewMoon >...
When you cast one you pass to the next one.
and the spell has 3 charges, but that's 3 considered different spells (202767, 202768, 202771), and everything charges/coodown/... is stored in New moon.
So, to determine the next spell to cast, I have a temp var that's called nextMoon where i store the next spell based on what i'm currently casting.
See here
AethysRotation - WoW Addon - Attempt to provide the useful and precise informations to execute the best possible DPS rotation in every situation.

The problem is :
When the player is casting Full Moon, the next spell is New Moon, so in nextMoon I have new moon.
BUT
newMoon is the ability tha you have in the codex and it switches it's icon by itself between the spells.
So, when I am casting fullMoon, nextmoon becomes newmoon
BUT
NewMoon still has the icon of FullMoon.

What i want is to tell the player taht when he is casting full moon, his next moon will be new moon but I can't do that...
I tried finding other spells with the same icon as new moon but that doesn't work
Everything works well for the rest because i can force cast HalfMoon and Fullmoon because that's different spells that stays with their icons

Hello
For some reason outlaw ghostly strike refreshes too early at around 10-13 seconds. Is this normal?
I thought the pandemic was around 4-5 seconds..

From https://mods.curse.com/addons/wow/aethysrotation?comment=19

f3ar2
Posted 5 hours ago
Hi! I found a few bugs for me.

1. When I load the first time the game, the rotation window is black screen.
2. I play as ret paladin and when I need to use the spenders (templar virdict or divine storm), the rotation window is black. Apparently it does not display correctly. Maybe because the rotation for this class - and spec was not updated for a long time.

Blunderbuss Icon was previously removed since it looks exactly like Between the Eyes and serves no purpose (Pistol Shot icon is used for all procs, blunderbuss or not)

It's been randomly re-appearing for me and driving me crazy - and when it does, it appears even for regular pistol shot opportunity procs. I finally managed to replicate this on target dummies, and it seems to involve changing equipment sets. if I change between sets with various combinations of Greenskins / Ravenholdt ring / Mantle (going OOC and then attacking the dummies), it will often cause this error, and the only way to revert to normal Pistol Shot icons is keep changing armor sets and (sometimes) reloadui. super annoying in M+

happens in all versions of addon and with no other addons loaded. Hopefully someone can replicate this.

There's an icon for what to use right now, but it's typically a very short window (1 or 1.5 sec GCD) to see the ability used and the next ability suggested, visually process the icon change, and decide which button to press (and typically AethysRotation would have a very small delay AFTER pressing the button to calculate the ability change as well, shortening that already short window)
Other rotation helpers I've used all have at least 1-step-forward predictive icons to help guide the brain in processing the next ability, and I found it heavily disconcerting not having that aid in AethysRotation as a new user.

Date: 2017-10-19 15:35:46
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\AethysRotation\Main.lua line 145:
Usage: AethysRotation_MainFrame:SetPoint("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY])
Debug:
[C]: SetPoint()
AethysRotation\Main.lua:145:
AethysRotation\Main.lua:131
Locals:
(*temporary) = AethysRotation_MainFrame {
0 =
Lock = defined @interface\AddOns\AethysRotation\Main.lua:95
ResizeButtons = defined @interface\AddOns\AethysRotation\Main.lua:60
Unlock = defined @interface\AddOns\AethysRotation\Main.lua:79
ResizeUI = defined @interface\AddOns\AethysRotation\Main.lua:38
}
(*temporary) = nil
(*temporary) = UIParent {
0 =
firstTimeLoaded = 1
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil

AddOns:
Swatter, v7.5.5724 (TasmanianThylacine)
AethysCache, v7.3.0.04
AethysCore, v7.3.0.05
AethysRotation, v7.3.0.06b
BlizRuntimeLib_enUS v7.3.0.70300
(ck=a2)

I've been having this pop on all my characters

Make options available in WoW built-in config panels.

isStunnable() much ?
Sephuz plz

Message: Interface\AddOns\AethysRotation_Shaman\Elemental.lua:272: attempt to compare boolean with number
Time: 10/18/17 16:34:15
Count: 1
Stack: Interface\AddOns\AethysRotation_Shaman\Elemental.lua:272: attempt to compare boolean with number
[C]: ?
Interface\AddOns\AethysRotation_Shaman\Elemental.lua:272: in function `?'
Interface\AddOns\AethysRotation\Main.lua:300: in function <Interface\AddOns\AethysRotation\Main.lua:290>

I know it's still a WIP, however I figured this might help push it along a little. Looks like it might run into this same error further down. This just happens to be the Ascendance part, there's the same code for Ice Fury and Lightening Rod.

Currently the config has the following spell ID as the 2 set buff "187878" while the id is "242284". This causes the addon to advise Crash Lightning on cooldown.

I've also removed S.CrashingStorm:IsAvailable() from the fillers since it was telling me to use Crash Lightning on cooldown when using this talent in a single target situation.

If i got the green fire activated as destro warlock, the "Auto/Green" Spell Icons setting doesn't actually work for me. The first spell i cast (Immolate) will be green, but then it starts switching to orange spells.

would it be possible to get and display the ability keybinding similar to how ovale can? i understand it could prob only be done with Action Bars that use the blizzard keybinds (IE Default/Elv and prob a few others i dont know). would be tremendously helpfull on alts that people havent quiet remembered whats keybinded where.

Implement a TimeSinceLastCast for spells
( More important than Prev GCD in order to finish Enh)

It appears there's something wrong with the Totem Mastery suggestion, it'll pop up several times in a row and won't progress.

Implement Prev GCD

3577x AethysRotation\UI.lua:109: attempt to index field 'Backdrop' (a nil value)
AethysRotation\UI.lua:109: in function `ChangeIcon'
AethysRotation\UI.lua:38: in function `ResetIcons'
AethysRotation\Main.lua:283: in function <AethysRotation\Main.lua:279>

Locals:
self = AethysRotation_MainIconFrame {
 ChangeIcon = <function> defined @AethysRotation\UI.lua:105
 Init = <function> defined @AethysRotation\UI.lua:89
 Part = <table> {
 }
 CooldownFrame = AethysRotation_MainIconCooldownFrame {
 }
 SetCooldown = <function> defined @AethysRotation\UI.lua:112
 SetupParts = <function> defined @AethysRotation\UI.lua:133
 InitParts = <function> defined @AethysRotation\UI.lua:115
 TempTexture = <unnamed> {
 }
 HideParts = <function> defined @AethysRotation\UI.lua:150
 0 = <userdata>
 texture = <unnamed> {
 }
}
Texture = "Addons\AethysRotation\Textures\9999000000"
(*temporary) = nil
(*temporary) = nil
(*temporary) = AethysRotation_MainIconFrame {
 ChangeIcon = <function> defined @AethysRotation\UI.lua:105
 Init = <function> defined @AethysRotation\UI.lua:89
 Part = <table> {
 }
 CooldownFrame = AethysRotation_MainIconCooldownFrame {
 }
 SetCooldown = <function> defined @AethysRotation\UI.lua:112
 SetupParts = <function> defined @AethysRotation\UI.lua:133
 InitParts = <function> defined @AethysRotation\UI.lua:115
 TempTexture = <unnamed> {
 }
 HideParts = <function> defined @AethysRotation\UI.lua:150
 0 = <userdata>
 texture = <unnamed> {
 }
}
(*temporary) = "attempt to index field 'Backdrop' (a nil value)"
AR = <table> {
 MaxQueuedCasts = 3
 CreateBackdrop = <function> defined @AethysRotation\UI.lua:57
 PulseInit = <function> defined @AethysRotation\Main.lua:234
 GetTexture = <function> defined @AethysRotation\Core.lua:42
 CastSuggested = <function> defined @AethysRotation\Core.lua:126
 PulsePreInit = <function> defined @AethysRotation\Main.lua:180
 LeftIconFrame = AethysRotation_LeftIconFrame {
 }
 MainFrame = AethysRotation_MainFrame {
 }
 GUISettings = <table> {
 }
 SuggestedIconFrame = AethysRotation_SuggestedIconFrame {
 }
 NameplateIconFrame = AethysRotation_NameplateIconFrame {
 }
 ToggleIconFrame = AethysRotation_ToggleIconFrame {
 }
 ChangePulseTimer = <function> defined @AethysRotation\Main.lua:300
 Commons = <table> {
 }
 Print = <function> defined @AethysRotation\Core.lua:31
 ResetIcons = <function> defined @AethysRotation\UI.lua:36
 Cast = <function> defined @AethysRotation\Core.lua:72
 Timer = <table> {
 }
 Locked = <function> defined @AethysRotation\Core.lua:224
 Pulse = <function> defined @AethysRotation\Main.lua:279
 CastLeftCommon = <function> defined @AethysRotation\Core.lua:106
 Ready = <function> defined @AethysRotation\Main.lua:295
 APLs = <table> {
 }
 CastLeftOffset = 1
 AoEON = <function> defined @AethysRotation\Core.lua:214
 CmdHandler = <function> defined @AethysRotation\Core.lua:138
 SetAPL = <function> defined @AethysRotation\Core.lua:37
 CastQueue = <function> defined @AethysRotation\Core.lua:91
 Nameplate = <table> {
 }
 CastLeftNameplate = <function> defined @AethysRotation\Core.lua:117
 MainIconFrame = AethysRotation_MainIconFrame {
 }
 CastSuggestedOffset = 2
 CastLeft = <function> defined @AethysRotation\Core.lua:111
 SmallIconFrame = AethysRotation_SmallIconFrame {
 }
 CastOffGCDOffset = 2
 GUI = <table> {
 }
 ON = <function> defined @AethysRotation\Core.lua:219
 CDsON = <function> defined @AethysRotation\Core.lua:209
}

no error after a reload an borders are set correctly

The cd/aoe/on/off toggle buttons seem to disappear permanently if I log into a class that is unsupported (Frost dk), and log into a class that is (Sub Rogue).

Reloading, turning it off and on, unlock/lock, nothing seems to bring it back.

Requires complete removal + reinstallation of the addon.

Atm, those settings are account-wide.
Make the character-wise §

When talenting into Serenity (level 100), after activating that skill the addon only shows the artifact weapon as rotation even when it is on cooldown.
The addon get stuck with that skill and only changes to Tiger Palm when i have less than 2 combo points. After getting 2 or more combo points it goes back to weapon skill stuck.

Talents im using when it happens:

• Eye of the tiger
• Chi Torpedo
• Ascension
• Leg Sweep
• Healing Elixir
• Hit Combo
• Serenity

When I switched from BM to MM, the buttons disappeared and nothing I have tried has brought them back. Screenshots will be attached to show what happens when I unlock. And even though it was unlocked, it is unmovable. It has something to do with my hunter because when I logged into my rogue to check, they were showing as normal.

I am getting this error when logging in:

Date: 2017-08-25 19:22:05
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\AethysRotation\Main.lua line 240:
   Usage: GetSpecializationInfo(specIndex[, isInspect[, isPet[, inspectTarget[, sex]]]])
Debug:
   [C]: GetSpecializationInfo()
   AethysRotation\Main.lua:240: PulseInit()
   AethysRotation\Main.lua:174:
      AethysRotation\Main.lua:171
Locals:
(*temporary) = nil

AddOns:
  Swatter, v7.2.5688 (TasmanianThylacine)
  AethysCache, v7.2.5.01
  AethysCore, v7.2.5.04
  AethysRotation, v7.2.5.10b
  Simulationcraft, v1.7.5
  BlizRuntimeLib_enUS v7.2.5.70200 <none>
  (ck=bc)

No icon atm for Ago at least

Frost DK - 3/2/1/3/2/3/1

Errors below

AethysRotation_DeathKnight\Frost.lua:480: attempt to index field 'S' (a nil value) AethysRotation_DeathKnight\Frost.lua:339: attempt to index field 'FreezingFog' (a nil value)
AethysRotation_DeathKnight\Frost.lua:339: in function <AethysRotation_DeathKnight\Frost.lua:329>
AethysRotation_DeathKnight\Frost.lua:487: in function `?'
AethysRotation\Main.lua:296: in function <AethysRotation\Main.lua:286>

Date: 2017-10-28 14:51:50
ID: 1
Error occured in: Global
Count: 1
Message: ...erface\AddOns\AethysRotation_Warlock\Destruction.lua line 332:
attempt to call method 'BuffRemainsP' (a nil value)
Debug:
...erface\AddOns\AethysRotation_Warlock\Destruction.lua:332: ?()
AethysRotation\Main.lua:332:
AethysRotation\Main.lua:322
Locals:
(*temporary) = nil
(*temporary) =

There are a few changes that need to be made to Frost Mage's rotation.

1. Ice Barrier. Should be up whenever possible.
2. Frost Nova. Instant cast and will triple damage from Ice Lance.
3. Spellsteal. If the target has a buff that can be stolen, steal it.
4. Invisibility/Ice Block. Good defensive spells. Not sure if they can be added, but they should be used before taking fatal damage.
5. Conjure Refreshment. I doubt this can be added, but if you don't have any Conjured Mana Buns, this should be cast to save time when you need them.
6. Blink/Shimmer. Can be used in combination with Frost Nova. If your target is within Frost Nova range, Nova then Blink/Shimmer out of damage rank.

Wind Walker monk assumes you have the energizing elixir and Whirling Dragon Punch talents. even if you did not take those talens