heroku / node-heroku-bouncer Goto Github PK
View Code? Open in Web Editor NEWeasy Heroku OAuth authentication for express
Home Page: https://npmjs.org/package/heroku-bouncer
easy Heroku OAuth authentication for express
Home Page: https://npmjs.org/package/heroku-bouncer
Am I doing something wrong? Here's my code: https://github.com/zeke/hk-web/blob/master/index.js
TypeError: Cannot read property 'email' of undefined
at Object.handle (/Users/zeke/code/hero/hk-web/node_modules/heroku-bouncer/lib/middleware.js:27:34)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.cookieSession [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/middleware/cookieSession.js:120:5)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.cookieParser [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/node_modules/cookie-parser/index.js:45:5)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.methodOverride [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/node_modules/method-override/index.js:48:5)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.urlencodedParser [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/node_modules/body-parser/index.js:104:36)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.jsonParser [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/node_modules/body-parser/index.js:71:36)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.expressInit [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/lib/middleware.js:30:5)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Object.query [as handle] (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/middleware/query.js:45:5)
at next (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:194:15)
at Function.app.handle (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/proto.js:202:3)
at Server.app (/Users/zeke/code/hero/hk-web/node_modules/express/node_modules/connect/lib/connect.js:65:37)
at Server.EventEmitter.emit (events.js:98:17)
at HTTPParser.parser.onIncoming (http.js:2108:12)
at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:121:23)
at Socket.socket.ondata (http.js:1966:22)
at TCP.onread (net.js:527:27)
cc @jclem
Related to #2.
It'd more flexible to have an authorization callback function that decides if an authorized user is allowed (rather than the hardcoded herokaiOnlyHandler
).
So for example:
app.use(bouncer({
oAuthClientID : 'client-id',
oAuthClientSecret : 'client-secret',
encryptionSecret : 'abcd1234abcd1234',
authCallback: function(user) { return /@example\.com$/.test(user.email); }
}));
See also the change to heroku-bouncer-python and my PR for heroku-bouncer.
I'll try to submit a PR for this, but I'm an express n00b so it might take me a bit :)
Hey @jclem , how can I use herokaiOnlyHandler to only allow heroku.com emails? Bit of a node - newb here any help appreciated!
app.use(bouncer({
oAuthClientID : process.env.HEROKU_OAUTH_ID,
oAuthClientSecret : process.env.HEROKU_OAUTH_SECRET,
encryptionSecret : process.env.HEROKU_ENCRYPTION_SECRET,
herokaiOnlyHandler : ???
}));
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.