These:

• https://github.com/heroku/heroku-nodejs-plugin/blob/d719ee495f68be88e321da8260e2df3cb7918fc5/src/index.js#L74
• https://github.com/heroku/heroku-nodejs-plugin/blob/d719ee495f68be88e321da8260e2df3cb7918fc5/src/index.js#L82

...should probably be debug calls so they're silent unless run with DEBUG=heroku:* or similar. Otherwise, it can appear that a user's app is logging errors/warnings when in fact it's a metrics dependency.

Hello team,

We're still seeing errors Cannot read properties of undefined (reading 'resume') in our applications. The same were described here last week - #113 but the applied fix doesn't seem to resolve the issue. Could you take a look once again, please?

Issue

If an app starts using a new Node version that is not yet supported by the Node metrics plugin, Node metrics silently disables metrics without explaining why.

Expected

There should be some logging that advises the user that the Node version is unsupported and metrics will be disabled. (Also, more closely released versions with plugins would be helpful, but we should still let the user know in that timeframe)

https://github.com/heroku/heroku-nodejs-plugin#development

You can collect and print out metrics locally by ...

Local development no longer works because of: https://github.com/heroku/heroku-nodejs-plugin/blame/master/src/index.js#L15-L23

Effectively making https://github.com/heroku/node-metrics-single-process defunct.

Additional, why not just publish this to NPM?

Cheers

We support Node 15 at the buildpack level, so it makes sense our metrics plugin supports it as well. Creating an issue to track that support.

(aside: currently, unsupported versions see the plugin silently skip installation, leaving the customer to ponder what happened.)

Having an app running Node v14.3 and using modules by "type" set to "modules" in package.json seems to throw an error after enabling runtime-heroku-metrics:

app[web.2]: internal/modules/cjs/loader.js:1216
app[web.2]: throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
app[web.2]: ^
app[web.2]:
app[web.2]: Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /app/.heroku/heroku-nodejs-plugin/index.js
app[web.2]: at Object.Module._extensions..js (internal/modules/cjs/loader.js:1216:13)
app[web.2]: at Module.load (internal/modules/cjs/loader.js:1049:32)
app[web.2]: at Function.Module._load (internal/modules/cjs/loader.js:937:14)
app[web.2]: at Module.require (internal/modules/cjs/loader.js:1089:19)
app[web.2]: at Module._preloadModules (internal/modules/cjs/loader.js:1345:12)
app[web.2]: at loadPreloadModules (internal/bootstrap/pre_execution.js:439:5)
app[web.2]: at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:71:3)
app[web.2]: at internal/main/run_main_module.js:7:1 {
app[web.2]: code: 'ERR_REQUIRE_ESM'
app[web.2]: }

The app crashes and cannot start due to:

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /app/.heroku/heroku-nodejs-plugin/index.js

(Perhaps this should have been posted to heroku-build-pack-nodejs)

@danielleadams

All v8 files are 38 bytes

https://github.com/heroku/heroku-nodejs-plugin/releases

Our pipeline broke because of this

Referring to the issue that was opened here: heroku/heroku-buildpack-nodejs#727. Opening an issue here to track any conversation and fixes.

Node Metrics as they are currently implemented on Heroku prevents Node worker threads from working. The error will appear as Module did not self-register.

The current best work around is to disable the Node Metrics. You can do this by running heroku labs:disable nodejs-language-metrics -a APP_NAME or doing it from the Heroku Dashboard (as pictured in the original issue: heroku/heroku-buildpack-nodejs#727 (comment)).