hensm / disable_tab_detach Goto Github PK

hi Matt

something i do myself and recommend others do is to always read the release notes and re-check privacy policies when updating any add-on, the problem being that a dev can sell or monetize the add-on which usually leads to unethical bullshit

so - i respectfully ask that you consider publishing the release notes so that they are available from about:addons -> avaliable updates -> show release notes

If there are several pinned tabs, the extension only works for the rightmost one, the other ones can be detached normally
version 0.0.4 tested

FF 61.0.1 64bit Linux
Doesn't work for pined tabs. And stops working for regular tabs after trying to detach pined tab

I don't want to detach pinned tabs (so find this exension valuable), I also don't want to accidentally detach regular tabs, but I do want the ability to detach these regular tabs from time to time. I'm not sure how to this could work with a reasonable UI though.

for pinned tabs only that seems to be a configuration checkbox: only prevent pinned tab detachment

for enabling easy recovery of non pinned tabs while still enabling them to be moved, perhaps if the same tab is detached twice in quick succession? One could also ask a Q with a pop up, but that seems more intrusive for preventing accidental detachment, the point would be to prevent accidental detachment, while providing a UI mechanism to allow purposeful detachment.

thoughts?

I see in the last commit 38d428b you've disabled the plugin if multiple tabs are selected. Appreciated.

Can you add a keyboard override as well? Like if shift is held down you can tear a single tab away? Or a keyboard shortcut that will pop the current tab to a new window?

There is no help, and no description of how to use this anywhere. Please add some documentation in the appropriate places.

Could you make it single window mode too?