Giter Club home page Giter Club logo

cljs.java-time's People

Contributors

henryw374 avatar joda avatar unmonoqueteclea avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

bigmlcom fooheads

cljs.java-time's Issues

Equals not found with advanced compilation

Hi, thanks for all the work you've done with all your libraries! I ran into an issue with tick when targeting JavaScript and I think it's an externs issue with this library. This is the issue I had created on tick's side juxt/tick#124.

When I run the below code with advanced compilation I'm getting the following error:

(ns core-test
  (:require [cljs.test :refer [deftest is]]
            [java.time :refer [Instant]]))

(deftest instant-equality
  (is (= (.parse Instant "2020-11-14T05:59:33.757Z")
         (.parse Instant "2020-11-14T05:59:33.757Z"))))
ERROR in (instant-equality) (TypeError:NaN:NaN)
expected: (= (.parse Instant "2020-11-14T05:59:33.757Z") (.parse Instant "2020-11-14T05:59:33.757Z"))
  actual: #object[TypeError TypeError: this.$equals$ is not a function]

Classes from packages different than js-joda/core

As far as I know, this library only offers methods from js-joda/core package.
However, js-joda contains three more packages:

  • @js-joda/timezone
  • @js-joda/locale
  • @js-joda/extra

I can help to add them, but I am not sure about how to start. If you could give me a piece of advise, I could try to add the missing packages, as I already did with some of the missing packages from js-joda/core

I think my issue is related to #1, but is there any workaround?

Thanks!

Published artifact is missing MIT license

Similar to: henryw374/time-literals#7

We have a deps.edn project which looks like this:

{:deps {org.clojure/clojure {:mvn/version "1.11.1"}
        com.xtdb.labs/core2-api {:local/root "api"}
        com.xtdb.labs/core2-core {:local/root "core"}
        com.xtdb.labs/core2-client {:local/root "client"}
        com.xtdb.labs/core2-server {:local/root "server"}
        com.xtdb.labs/core2-datasets {:local/root "modules/datasets"}

        com.xtdb.labs/core2-kafka {:local/root "modules/kafka"}
        com.xtdb.labs/core2-s3 {:local/root "modules/s3"}
        com.xtdb.labs/core2-jdbc {:local/root "modules/jdbc"}
        com.xtdb.labs/core2-bench {:local/root "modules/bench"}

        integrant/repl {:mvn/version "0.3.2"}
        org.slf4j/slf4j-api {:mvn/version "1.7.36"}
        ch.qos.logback/logback-classic {:mvn/version "1.2.10"}
        cheshire/cheshire {:mvn/version "5.10.0"}
        com.cognitect/transit-clj {:mvn/version "1.0.324"}

        org.clojure/data.csv {:mvn/version "1.0.0"}
        org.clojure/tools.namespace {:mvn/version "1.2.0"}
        org.clojure/test.check {:mvn/version "1.1.1"}

        org.postgresql/postgresql {:mvn/version "42.2.20"}
        org.xerial/sqlite-jdbc {:mvn/version "3.36.0.3"}

        com.widdindustries/time-literals {:mvn/version "0.1.6"}
        io.github.cognitect-labs/test-runner {:git/tag "v0.5.0" :git/sha "b3fd0d2"}
        com.clojure-goes-fast/clj-async-profiler {:mvn/version "0.5.1"}}

;; ....
}

If I run the Neo4j Licensing plugin, like so:

$ mvn org.neo4j.build.plugins:licensing-maven-plugin:check -DfailIfMissing=false && \
  mvn org.neo4j.build.plugins:licensing-maven-plugin:collect-reports && \
  mvn org.neo4j.build.plugins:licensing-maven-plugin:aggregate

...it complains about two libraries:

[WARNING] Licensing: The artifact cljs.java-time:cljs.java-time:jar:0.1.19 has no license specified.
[WARNING] Licensing: The artifact com.widdindustries:time-literals:jar:0.1.6 has no license specified.

Is it possible to get the MIT license embedded in the release jar so automated licensing tooling can see it?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.