henrikrexed / openfeature Goto Github PK

View Code? Open in Web Editor NEW

0.0 1.0 0.0 677 KB

Shell 84.76% JavaScript 15.24%

openfeature's People

Contributors

Watchers

openfeature's Issues

Argo bug suspected: multiple OutOfSync -> Synced logs

I take an app OutOfSync and get 1 log entry. Good.
I sync the app and get 2 log entries. Not good.

Impact: If we take OutOfSync -> InSync log lines as "deployments" then the stats are wrong.

$ kubectl logs argocd-application-controller-0 | grep OutOfSync

time="2023-02-02T00:32:32Z" level=info msg="Updated sync status: Synced -> OutOfSync" application=fib3r dest-namespace= dest-server="https://kubernetes.default.svc/" reason=ResourceUpdated type=Normal
time="2023-02-02T00:35:06Z" level=info msg="Updated sync status: OutOfSync -> Synced" application=fib3r dest-namespace= dest-server="https://kubernetes.default.svc/" reason=ResourceUpdated type=Normal
time="2023-02-02T00:35:06Z" level=info msg="Updated sync status: OutOfSync -> Synced" application=fib3r dest-namespace= dest-server="https://kubernetes.default.svc/" reason=ResourceUpdated type=Normal

Asked in Argo Slack.

Queries suddenly broken

Working: fetching logs and filtering for those containing { works.
Broken: fetching logs, filtering as above then parsing content to JSON = broken (overnight).

argocd-notifications-cm sed work

argocd/argocd-notifications-cm.yaml template should be:

apiVersion: v1
kind: Secret
metadata:
  name: argocd-notifications-secret
stringData:
  dt-env: "DT_TENANT_TO_REPLACE"
  dt-api-token: "DT_TOKEN_TO_REPLACE"
  webhook-env: "WEBSOCKET_URL_TO_REPLACE"
type: Opaque

Then instructions for sed when working with argocd/argocd-notifications-cm.yaml should be:

# User to set the variable below
WEBSOCKET_URL=https://webhook.site/abcd1234-1234-abcd-abcd-1234aaaa2341

sed -i "s,WEBSOCKET_URL_TO_REPLACE,$WEBSOCKET_URL," argocd/argocd-notifications-secret.yaml
sed -i "s,DT_TENANT_TO_REPLACE,$DT_TENANT_URL," argocd/argocd-notifications-secret.yaml
sed -i "s,DT_TOKEN_TO_REPLACE,$DATA_INGEST_TOKEN," argocd/argocd-notifications-secret.yaml
kubectl -n argocd apply -f argocd/argocd-notifications-secret.yaml

# git restore to remove sensitive info and prevent accidental commits of sensitive keys
git restore argocd/*
kubectl -n argocd apply -f argocd/notifications-cm.yaml

argocd login command tweak

This didn't work for me: argocd login https://argocd.$IP.nip.io --username admin --password $ARGO_PWD

This did: argocd login argocd.$IP.nip.io --username admin --password $ARGO_PWD --insecure

Create KLT Task to Fire BizEvent

Create a task that sends bizevents to DT.

This is more complex than a standard API call because it requires multi-step working with OAuth.

get open problems for each app

fetch events
| event.kind == "DAVIS_PROBLEM"
...

TODO...

fib3r-ingress URL hardcoded

openfeature/fib3r/helm/fib3r/templates/service.yaml

Line 24 in d2690ce

- host: "fib3r.34.159.208.207.nip.io"

Needs to be parameterised and updated via sed.

fib3r-ingress namespace is missing

After #5 is resolved, the argocd app sync command syncs fibonacci fine but fib3r fails: Namespace for fib3r-ingress networking.k8s.io/v1, Kind=Ingress is missing.

Presumably because namespace is missing.

argocd app sync - no app found

$ kubectl get applications
NAME        SYNC STATUS   HEALTH STATUS
fib3r              
fibonacci

argocd app sync fib3r shows: FATA[0001] rpc error: code = NotFound desc = error getting application by name: applications.argoproj.io "fib3r" not found

Missing sed replaces

argocd/applications/yaml references a placeholder:

repoURL: 'GITHUB_REPO_TO_REPLACE'

This should probably be replaced using sed during the previous instructions.

I.e. this:

GITHUB_REPO_URL=https://github.com/agardnerit/openfeature-henriks-demo
GITHUB_USER=agardnerit
GITHUB_PAT_TOKEN=
argocd repo add $GITHUB_REPO_URL --username $GITHUB_USER --password $GITHUB_PAT_TOKEN --insecure-skip-server-verification

Becomes this:

GITHUB_REPO_URL=https://github.com/agardnerit/openfeature-henriks-demo
GITHUB_USER=agardnerit
GITHUB_PAT_TOKEN=
sed -i "s,GITHUB_REPO_TO_REPLACE,$GITHUB_REPO_URL," argocd/applications.yaml
git add argocd/applications.yaml && git commit -m "update repo url" && git push
argocd repo add $GITHUB_REPO_URL --username $GITHUB_USER --password $GITHUB_PAT_TOKEN --insecure-skip-server-verification

Note: This needs to be done on the GitHub.com fork and not a local copy

readme typo: argicd

Tiny typo in readme: argicd app sync fib3r should be argocd app sync fib3r

csi-provisioner hasn't finished setup

$ kubectl -n argocd get pods
NAME READY STATUS RESTARTS AGE
argocd-application-controller-0 0/1 Init:0/1 0 4m29s

  Warning  FailedMount  2m12s                kubelet            Unable to attach or mount volumes: unmounted volumes=[oneagent-bin], unattached volumes=[oneagent-share injection-config data-ingest-enrichment kube-api-access-hxjg8 argocd-repo-server-tls argocd-home data-ingest-endpoint oneagent-bin]: timed out waiting for the condition
  Warning  FailedMount  5s (x10 over 4m15s)  kubelet            MountVolume.SetUp failed for volume "oneagent-bin" : rpc error: code = Unavailable desc = version is not yet set, csi-provisioner hasn't finished setup yet for tenant: abc12345

otel-collector.yaml > observability/openTelemetry-manifest_prometheus.yaml

sed -i "s,DT_TOKEN_TO_REPLACE,$DATA_INGEST_TOKEN," observability/otel-collector.yaml doesn't work as observability/otel-collector.yaml no longer exists.

Change readme to point sed to observability/openTelemetry-manifest_prometheus.yaml

Also add sed to update this placeholder: endpoint: DT_URL_TO_REPLACE/api/v2/otlp

oteld-collector health_check service does not exist

$ kubectl logs oteld-collector-zdjj6
2023/01/31 04:11:53 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2023/01/31 04:11:53 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
Error: failed to get config: invalid configuration: service references extension "health_check" which does not exist
2023-01-31 04:11:53.978942 I | collector server run finished with error: failed to get config: invalid configuration: service references extension "health_check" which does not exist

Perhaps this needs to be added?

...
processors:
...
extensions:
  health_check: {}
    endpoint: 0.0.0.0:8889
  logging:

service:
  extensions: [health_check]

User "system:serviceaccount:dynatrace:otelcontribcol" cannot list resource "pods" in API group "" at the cluster scope

After I removed health_check in #10, I get the below errors in the oteld pod logs.

I don't know the impact of this. Maybe an issue, maybe not.

E0131 06:26:53.740122       1 reflector.go:140] k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1.Pod: failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:dynatrace:otelcontribcol" cannot list resource "pods" in API group "" at the cluster scope
W0131 06:26:54.179592       1 reflector.go:424] k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:dynatrace:otelcontribcol" cannot list resource "pods" in API group "" at the cluster scope
E0131 06:26:54.179633       1 reflector.go:140] k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1.Pod: failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:dynatrace:otelcontribcol" cannot list resource "pods" in API group "" at the cluster scope