helpfulhuman / react-project-legacy- Goto Github PK

Unless proven otherwise, I believe it may be ideal to implement an AJAX solution that allows global options to be set. This way, variables such as server hostname or user token don't have to be constantly passed around to each action creator or component that uses it.

Note: Currently using superagent

Example

import Request from './services/Request'

Request.globals.hostname = 'http://someurl.com'
Request.globals.headers.Authorization = 'Bearer xxxxxxxx'

I don't see an image loader in the webpack.config.js. Is this missing or are images being loaded another way?

Perform initial load on the Node server to allow for faster page loads and hack-free support for search engine crawling.

Putting the authentication redirection in the action creators make sense but may be an issue if the store hasn't been updated before the next (possible guarded) route is loaded.

Example: I am logged in and want to log out.

1. Upon logging out I should be redirected to the login page.
2. If I am still logged in while hitting the login page, I should be redirected to the home page.
3. Currently, the transitionTo('login') method is being called prior to dispatching the LOGOUT action.

This would mean that the logout action would redirect you to the login page, only for it to send you back to the home page and then possibly sending you back to the login page once store is updated.

At the moment, this boilerplate is only ready for dev and not production. We did this for MHM but since I'm not aware what parts of that are MHM specific, I'll defer to our React Captains™ for this implementation.

Forms can be kind of tricky in React + Flux, at least when it comes to form errors and validation. Adding a form example with input validation and/or server error would be super helpful.

Possible Resource

Need to decide which testing tools to use:

• Jest
• Mocha + Chai
• Karma

Linting support for ES6 and rule set up for Javascript Code Style.

Need to decide which testing tools to use:

• Jest
• Mocha + Chai
• Karma

findDOMNode is not necessary. Rather than findDOMNode(this.refs.email).value; you can simply write this.refs.email.value;

Integrate stylus examples into the application along with recommended file structure for bundling styles with their related components. Ideally, it would be good to base this on the work we're doing internally with Helpful UI.

Also need to decide whether or not to allow JS to handle styling with import or use Gulp ahead of time to generate CSS based on the bootstrapping main.styl file we presently have.

Need to solidify file structure and create an opinion based on common best practices for the file structure of components, stores, services, actions, etc. Once we have a standard created, we can begin publishing a README for it.