helmasaur / zodiac-signs Goto Github PK

The test file has been completed (#9) but undefined is returned for values which are linked through a key. It's the case for element.

The commented lines are the parts that have to be checked.

For example:

• quality
• planets
• opposite sign

2020 -> 2023

The thanked Discord servers don't have a link.

• Programming Discussion: https://discord.gg/progdisc
• The Coding Den: https://discord.gg/code

In the function getSignByName(), the language argument is missing in the fucntion getNames().

hi.
how can i import it by ECMAScript?

The fr-FR language format isn't managed by the code, so it would always return the english string.

Same as #48, space missing:

The packages and my username is put back to lower case like most of GitHub.

The month and day integer is now stored in an object (7932b14). Although, the example in the readme file hasn't been updated.

Several closing parenthesis are missing in the readme file. I suspect copy-pasting 👀.

Both Conservancy and the Git project are aware that the initial branch name, ‘master’, is offensive to some people and we empathize with those hurt by the use of that term.

https://sfconservancy.org/news/2020/jun/23/gitbranchname/
https://github.com/github/renaming

I really love this package it's so easy to use but I have a suggestion, you should include facts with each sign. Also, I would really love to help you with this project if you are up to!

2020 -> 2023

Thank the author of the translation (#32) in the readme file.

List the data a sign have.

Swedes are all about astrology.

This piece of code appears many times:

let signsLocale;
try {
	signsLocale = Object.values(require(`./locales/${language}/zodiac.json`));
} catch {
	signsLocale = Object.values(require('./locales/en/zodiac.json'));
}

Is there a way where the file is imported once only?

Possibilities:

• zodiac.getSignByDate()
• zodiac.getSignByName()

Add keywords to:

• the GitHub repository
• package.json

Update

Remove this sentence: https://github.com/Helmasaur/Zodiac-signs/blame/master/README.md#L79

To keep dates valid, the format which is used is YYYY-MM-DD. A function should be written to return the date as a local date string without the year.

Function to use: Date.prototype.toLocaleDateString().

What happens if a wrong argument is given?

For example:

console.log(zodiac.getSignByName('♋️'));
// or
console.log(zodiac.getSignBySymbol('♋️'));