helixquar / asciidecorator Goto Github PK

Requested in: #2 (comment)

The option for "ASCII Decorator: Font Selector" no longer seems to be working consistently. I've only gotten it to work once, and I don't even remember what I did to get it to work, as I've been unable to reproduce it. The preview still shows up in the Output window, and as a workaround I can copy and paste the text from there to where I need it.

"ASCII Decorator: Default Font" still works fine.

Hi,

Do you think you could publish your plugin to https://open-vsx.org as well? Thank you.

The error:

Property 'label' does not exist on type 'string | T'.
  Property 'label' does not exist on type 'string'.

In file: extension.ts
On the ff. block:

    let options = <vscode.QuickPickOptions>{
        placeHolder: 'Select a font',
        matchOnDescription: true,
        onDidSelectItem: item => {
            if(!txt)
            {
                return;
            }

            fontTestWindow.clear();
            fontTestWindow.append(
                figlet.textSync(txt, {
                font: item.label,
                horizontalLayout: 'default',
                verticalLayout: 'default'
            }));
            fontTestWindow.show(true);
        }
    };

Hi, how could you wrap the output in comment tags?

@todo: Profile if this occurs before ncu -u mis-commit.

If the text selected to change is indented (say in a comment indented to align with a function in a class), the first line of the generated ASCII font is indented as expected, but every following line has no indent and must be indented manually.

describe('Tests', function() {
  /*
  Test
  */
  describe('Express', function() {
  });
});

becomes

describe('Tests', function() {
  /*
  888888 888888 .dP"Y8 888888 
  88   88__   `Ybo."   88   
  88   88""   o.`Y8b   88   
  88   888888 8bodP'   88   
  */
  describe('Express', function() {
  });
});

instead of

describe('Tests', function() {
  /*
  888888 888888 .dP"Y8 888888 
    88   88__   `Ybo."   88   
    88   88""   o.`Y8b   88   
    88   888888 8bodP'   88   
  */
  describe('Express', function() {
  });
});

Could you please add a version of the default font without shadow? Personally, I like the 'cleaner' look :) Great job on the extension, btw!!