hei-school / hei-admin-api Goto Github PK

Filter by ref, by first name and by name.

To address in this ticket if possible: #38

For the moment, we manually attach AmazonCognitoPowerUser

ContainingIgnoreCase

Do not forget to precise this in the OpenAPI spec.

In particular, there are some parameters that should be required and aren't yet.

For the moment, AmazonEventBridgeFullAccess policy is manually attached to taskRole through AWS Console.

Sentry warning spring.jpa.open-in-view is enabled by default. Therefore, database queries may be performed during view rendering. Explicitly configure spring.jpa.open-in-view to disable this warning

Vlad is against it, but we don't mind: we choose simplicity over performance on this one.
https://vladmihalcea.com/the-open-session-in-view-anti-pattern/

• Only attribute is email
• Create a Public Client app, with read-only capabilities (people that can successfully log through this app, typically from a web browser, can only read their information, not modify them)
• Configure email/SMS contents

#59

Commit 74166d4 uses the Cognito emulator from https://github.com/jagregory/cognito-local. Unfortunately, that emulator does not support AdminInitiateAuth which makes it impossible to get authentication token. Keep an eye on that project, they might eventually implement that feature.

Alternately, Localstack provides support for Cognito. However, they do so in the Pro version only https://localstack.cloud/features/.

• This is because we cannot send more than 10 UserUpserted events at once
• In such a failure, database entries should be rolled back ==> creation should be @transactional!

Nb of users that can be created in batch is bounded by the number of events we can send at once. This is because send multiple batch of events and that some of them fail, we have now way of taking back all the other events that were successfully sent. As EventBridge.PutEvents can only handle 10 events at once, we must limit user creation to 10 users
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_PutEvents.html

• Migrate ECS to Lambda
• Migrate RDS Postgres to RDS Aurora

In particular, document how to get Cognito tokens?

Related issue: #10

Should be LATE but is UNPAID https://dev.admin.hei.school/#/fees/student1_id--91229af6-4815-46bf-8056-224d598f37cd/show

Our current pagination is translated into offset-limit pagination by Postgres.
The more P=page*pageSize increase, the longer Postgres takes to process the request.
In particular, P could lead to a full scan.
To prevent this, P should be bounded.
Eg: P_MAX=1_000 ensures that a query will never scan more than P_MAX+MAX_PAGE_SIZE.
P_MAX=1_000 is large enough to cover all the use cases of the API.
* We don't expect consumers to dump the whole database
* Consumers are only expected to find users by weak comparison on
* ref
* firstname
* name

Do not persist fee.status and fee.remaining_due in db. Just compute them on the flight, in memory.

Do not create new flyway script migration. Just edit the current v0.3 then manually fix dev db accordingly.

When done, squash obtained commit with the fees commit in dev

https://www.baeldung.com/spring-boot-bean-validation

Answer Bad request and put the criminal field in the message

• Create SQS queue and give DL queue to it. That queue Q is the mailbox of haapi.
• Create rule for the used event bus: route all events from haaapi to its own mailbox (Q).
• AmazonSQSFullAccess for ECS Task role (should be refined)

Fee.comment should be moved into CreateFee.comment

Same for Payment

How to automatically fix checkstyle warnings and errors?

Are the following suspicious Sentry issues coming from some misconfigured tests?

• https://sentry.io/organizations/hei-school/issues/2987827629/?project=6160544&query=is%3Aunresolved&statsPeriod=14d
• https://sentry.io/organizations/hei-school/issues/2987827603/?project=6160544&query=is%3Aunresolved&statsPeriod=14d
• https://sentry.io/organizations/hei-school/issues/2987832458/?project=6160544&query=is%3Aunresolved&statsPeriod=14d
• https://sentry.io/organizations/hei-school/issues/2987827477/?project=6160544&query=is%3Aunresolved&statsPeriod=14d