Giter Club home page Giter Club logo

imagemachine's Introduction

Hello there ๐Ÿ‘‹

name: Hector Rios
title: Senior Software Engineer
site: https://hectron.github.io/
location: Chicago, IL, USA
interests:
  - photography
  - civic tech
  - hobby projects
  - twinkly midwest-emo music

imagemachine's People

imagemachine's Issues

Refactor mapper.py

The new mapper.py file has a few areas where it can improve:

  • There is a method called get_new_columns which returns an OrderedDict. This method should read from a configuration file which maps the new fields to the old fields.
  • The printing should be using the util conditional print functionality.
  • There is a part where we bastardize the data. This should get moved to another place.

Improve these things and then submit a pull request for this.

Add filters to docs/filters.txt

Context

The mapper maps an old Facebook Power Editor template into a new one. Therefore, the new template can be de-dupped using Excel's de-duping abilities.

Cause

There is a new format.

Solution

Add the following filters:

B, L, CV, GP to the docs/filters.txt and label it.

Confirm folder existence in csv_to_xlsx

Currently, we are assuming there is a folder called archived in csv_to_xslx.py. Update this logic to confirm to safely create a folder.

Ideally, create a utility function which creates a relative directory if one does not exist.

Remove `setup.py`

Context

It's a general practice to have a file in the main directory of a python project called setup.py. This file is in charge of moving everything into the right place, and getting the user to a good starting point to use/develop the project.

Cause

The setup.py is recommended, but there is no need for it here. The main logic lives within image_machine/image_machine.py.

Solution

Remove setup.py.

General cleanup

Context

There are a lot of unused methods which should be updated or removed.

Cause

There was a lot of changes in the original ask, so there might be some methods that are no longer necessary.

Solution

Identify the candidates to be removed in the pull request. Remove the methods that are able to be removed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.