Devepxress is very poplular datagrid system for Angular, React etc
Since hebcal >=5.0, there is an error
TypeError: Method get Intl.DateTimeFormat.prototype.format called on incompatible receiver undefined
after initlize hebcal

This is the error in the devtools console:
main.ts:11 ERROR TypeError: Method get Intl.DateTimeFormat.prototype.format called on incompatible receiver undefined
at get format ()
at format (index.mjs:2029:55285)
at formatDateTime (date.js:41:12)
at date.js:27:16
at Object.format (date.js:207:20)
at Object. (class.js:18:27)
at object. [as format] (dependency_injector.js:29:46)
at Object.format (format_helper.js:41:20)
at object. [as format] (dependency_injector.js:29:46)
at Object.formatValue (m_utils.js:121:21)

Below a link for very minimal example to see the error.
How to install the example:

1. git clone https://github.com/aepshtin/test-hebcal-dx
2. cd test-hebcal-dx
3. npm i
4. ng s

then open the browser at: http://localhost:4200/

and see the error in the console
Just comment out the Zman initilze and see how it works well

In version 4.5.1 it works well.
But i want to use version >=5.0 becuse of the elevation calculation.
Thanks a lot

I'm not sure how to express my issue, will try my best.
Currently, HDate is calculated based on a Gregorian date, but the problem is that the gregorian date changes at midnight while the hebrew date changes at nightfall..
If i want to check a datetime for any event, i can't just rely on HDate since it will return results based on the gregorian date which won't change till midnight. so i also need to check if it's after nightfall and considered next hebrew date.
Is it possible to add the functionality of calculating the HDate based on the time and GeoLocation which should change at nightfall?
I hope this is clear enough.
Thanks!

When an invalid date is passed to the constructor of HDate(), normally it is handled by calling fix(date), which will either increment or decrement the month to return a valid date. For example, new HDate(30, 2, 5784) will roll over and return HDate {month: 3, day: 1, year: 5784}.
This does not work for Adar in a non leap year, so a call to new HDate(30, 12, 5783) will not return HDate {month: 1, day: 1, year: 5783}
as I expected, rather HDate {month: 12, day: 1, year: 5783}.
This is because of this line of code increments the month to 13, and then this next function decrements it back to 12.
A fix for this would be to replace date.mm += 1; in here with

 if (date.month === months.ADAR_I && !date.isLeapYear()) {
      date.month = months.NISAN;
    }
    else date.month += 1;

I don't want to open a PR, because I was unable to test locally.

Hello, I've been using your package for a React project that was based on the Create React App framework and have had no issue utilizing it. Since the framework is deprecated and has security issues, I need to migrate our project to Vite.

Unfortunately, I encountered the following error when attempting to run it:

Following the link mentioned in the warning above, I see that the issue is caused by a Node module, events, being used. Since Vite does not automatically apply polyfills, this error appears.

Though I could install the polyfill to fix this issue, I noticed that the Readme mentions this package is meant to be compatible with browsers, so I wanted to open this issue.

const hd = new HDate(date.day, month, date.year);
return hd.renderGematriya(true);

by this two lines of code we can able to make the conversion of Hebrew date to Hebrew text date (כ״ד בְּתַמּוּז תשפ״ג). but we can't do Hebrew text date to hebrew date(24th of Tamuz, 5783) or Gregorian Date(Wed, 12 July 2023) using the library. i have checked whole documentation but not found anything solid which gives me the option to do the above mentioned task.

Unless I am missing it, I cannot find a single step way to turn a JS Date into the HDate for the same day. Related question (maybe just needs documentation): What is the difference between: getBirthdayOrAnniversary(hyear, gdate) ⇒ HDate
and
getYahrzeit(hyear, gdate) ⇒ HDate ?

This is more of a feature request. Is it possible to add the ability to get candle lighting for a HDate?

@mjradwin I used till now version 2.6.1, and it worked perfect.
I upgraded to latest version, and when I try to use new HDate(), I get the following error: "ERROR TypeError: hebcal_core__WEBPACK_IMPORTED_MODULE_1_.HDate is not a constructor"

HebrewCalendar.getHolidaysOnDate(date, false) returns an Event array if there are any events for the given date. How do I select what kind of events I want? For example, if I only want Chagim, how would I do it?

I see Hebcal has flags. However, .getHolidaysOnDate does not have an option to pass them in. I also see that Event has a mask field, which seems to identify the specific holiday. However, how can I figure out which category a holiday is a part of?

Via the API, is there a way to get the weekday Torah leyning? I know it's the first aliyah broken up into 3 parts but it would be handy to be able to pull that from the response as well.

Fasting times for Tish'a B'Av shouldn't show up in export with Candle lighting and Havdalah only

Originally posted by @essel-dev in #181 (comment)

When generating a calendar with candle lighting times in Typescript, the TimedEvents representing candle lighting do not include any way to actually access the timing information.

import { HebrewCalendar, Location, TimedEvent } from "@hebcal/core";

HebrewCalendar.calendar({
    year: 2022,
    month: 8,
    candlelighting: true,
    location: Location.lookup("Baltimore"),
    noHolidays: true
}).forEach(event => {
    console.log(event.eventTime); // <-- Refuses to compile
    console.log((event as TimedEvent).eventTime); // <-- Refuses to compile
});

The .d.ts entry for TimedEvent does not include entires for eventTime or eventTimeStr, and the class itself does not expose any getter methods for the same.

Property 'eventTime' does not exist on type 'TimedEvent'.

Trying to retrieve the information from the Gregorian Date also fails, because timing information is lost in the conversion to HDate.

HebrewCalendar.calendar({
    // ...
}).forEach(event => {
    console.log(event.getDate().greg()); // <-- Prints 2022-08-05T00:00:00Z (for example)
});

I'm happy to write a PR if you'd like, but I didn't know if you manually edit the .d.ts or if it's generated, or if you wanted to expose the properties or write getters for them.

Is it possible to use hDate.renderGematriya() without nikud?

I see
new hDate().renderGematriya()
and
new hDate().render('he-x-NoNikud').toString()

But I don't see any way to combine the two, so we get the Gematriya without Nikud.

hi wrote the following code:

import {HebrewCalendar, months, HDate, Location, Event, ParshaEvent, Zmanim} from '@hebcal/core';

const loc = Location.lookup('Jerusalem');
const wed = new Date(2023,9,20);
const zeman = new Zmanim( wed, loc.getLatitude(), loc.getLongitude());

console.log("sunrise:" + zeman.sunrise())
console.log("sunset:" + zeman.sunset())

the output i'm getting is :

sunrise:Fri Oct 20 2023 06:45:38 GMT+0300 (Israel Daylight Time)
sunset:Fri Oct 20 2023 18:01:50 GMT+0300 (Israel Daylight Time)

it's writing "Fri" as for Friday instead of Wednesday
also, it's outputting GMT+0300 instead of +2
also it's outputting "Oct" instead of September

what am i doing wrong ?

if i send in the Date (2023 , 8 , 20) then it will get the right resualts (meaning you are still using based on 0-11 months
but still the GMT is wrong

maybe it's not relevant any more. but if it's caused by an algorithm problem it could occur again.

thank you!

edit: mjradwin you are right. my bad.

While the docs specifies that it accepts a locale, it has not been implemented.

In version 5.2.1 I could access to the elevation of location like:
let c = Location.lookup(someCityName).getElevation();
In version 5.2.2, I can't any more
Can you fix it?
Thanks a lot

I am encountering a TypeScript type declaration error in my React TypeScript project when using the package. Although the package includes type declarations (hebcal.d.ts), TypeScript fails to recognize them.

The error message I receive is as follows:

Could not find a declaration file for module '@hebcal/core'. '../node_modules/@hebcal/core/dist/index.mjs' implicitly has an 'any' type. There are types at '../node_modules/@hebcal/core/hebcal.d.ts', but this result could not be resolved when respecting package.json "exports". The '@hebcal/core' library may need to update its package.json or typings.

Interestingly, when I remove the following lines from the package.json of the package:

"exports": { 
    "import": "./dist/index.mjs",
    "require": "./dist/index.js"
  },

The error is resolved. However, my concern is that when I deploy my project to platforms like Vercel or Netlify, I am unable to access and modify the package.json file to fix the issue.

Thanks for making Hebcal available!

I found some data missing when trying the following imports into Google Calendar, see attached screenshot:

1. Zmanim for Candle lighting and Havdalah only highlighted in blue.
2. Zmanim for all events highlighted in grey.

With export 1 the Havdalah times are missing for:

1. motzei Rosh Hashana
2. motzei Yom Kippur

This happens yearly.

All the ways I try to generate it render it in English.

why can i add this calendar automatically to icloud?

This https://www.hebcal.com/hebcal?v=1&maj=on&min=on&nx=on&mf=off&ss=off&mod=off&i=off&d=on&D=off&o=on&a=off&c=off&s=on&F=off&geo=none&lg=h&yt=H&year=5782

Is putting the square for Channukah on Sunday, the 24 of Kislev. Yes Channukah is at night, but that's always like that - Channukah should be placed on the next day, just like all the Holidays are.

How to get an object of the whole month or year
Like hebcal() in the hebcal-js package?

Thank you very much for making hebcal ES6 compatible!
I am trying to use it in my Expo/React Native project, but, unfortunately, the package is crashing with various errors. E.g.

TypeError: undefined is not an object (evaluating '_core.HebrewCalendar.calendar')

You can see it yourself by installing expo, doing expo init, and then pasting some of your demo code into the App.tsx.

Any help is greatly appreciated!

the render function on Rosh Hashana event always returns the English string even when the locale parameter is set to 'he' or 'fr'
it's works fine for Rosh Hashana day 2 but not for day 1

for example:
events /*
[
HolidayEvent {
date: HDate { month: 7, day: 1, year: 5781 },
desc: 'Rosh Hashana 5781',
mask: 33,
attrs: [Object: null prototype] {}
},
HolidayEvent {
date: HDate { month: 7, day: 2, year: 5781 },
desc: 'Rosh Hashana II',
mask: 5,
attrs: [Object: null prototype] {}
}
] */

var translateToHebrew = events.map(ev=>ev.render('he') ); //[ 'Rosh Hashana 5781', 'רֹאשׁ הַשָּׁנָה יוֹם ב׳' ]

Hi
The options.hour12 set to true seems to always return the 24h format in the generated strings (like Molad infos in the Mevarhim Shabbat object). Even if i force the local the string is in 24h format.
Is there something specific to do to have the 12h format in the result strings ?
Thank you

So far the only way I can see is to get all events for a month and check for each event if it's on the same day, is there a way to get all events for a day? and if yes can I get only specific event types??

line #362

export function addLocale(locale: string, data: LocaleDate): void;

second argument should be LocaleData instead of LocaleDate

The Eisenberg triennial cycle for Va'yekhel-Pekudei seems to say that when these sections are read together in years 1 and 2 of a cycle and are apart in year 3, as is the case for 5780, 5781, and 5782, the reading from Va'yekhal is Ex: 35:1-36:19. Hebcal reports Ex: 36:20 - 28:20.

I've attached an annotated image of the relevant page from the Eisenberg document for Va'yekhel-Pekudei and marked the years corresponding to years 1 - 3, and indicated what Hebcal reports.

There also seems to be a discrepancy for Tazriah-Metzorah. The 5780-5782 cycle also seems to be a together, together, separate group but Hebcal does not report Lev 12:1 - 13:28.

It appears that Hebcal is using the next cycle, but that doesn't work for Acharei Mot, later this year.

Perhaps Hebcal doesn't use the Eisenberg calendar system to which Hebcal links? Have I misinterpreted Eisenberg's tables?

Hi
For MGA Shema and Shacharit there 3 opinion, here is a screenshot from MyZmanim showing them:

Using the zmanim.sofZmanShmaMGA() and zmanim.sofZmanTfillaMGA() seems to return the time according to fixed 72 minutes, what the best way to get the time using 72 minutes as 16.1 degrees ?

Backport bugfix from hebcal/hebcal-es6

mkdir -p /tmp/hc
cd /tmp/hc
npm init -y
npm i typescript @hebcal/core @hebcal/noaa tslib
echo "export * from '@hebcal/core'" > index.ts
cat >tsconfig.json <<EOL
{
  "include": ["index.ts"],
  "compilerOptions": {
    "target": "ES2022",
    "module": "NodeNext",
    "declaration": true,
    "moduleResolution": "NodeNext",
    "importHelpers": true,
    "sourceMap": true,
    "inlineSources": true
  }
}
EOL
npx tsc

node_modules/@hebcal/core/hebcal.d.ts:1:29 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@hebcal/noaa")' call instead.

1 import { GeoLocation } from '@hebcal/noaa';
~~~~~~~~~~~~~~

Found 1 error in node_modules/@hebcal/core/hebcal.d.ts:1

See #365

Example call to RSS API:
https://www.hebcal.com/shabbat?cfg=r&leyning=off&geonameid=3173435

Output: Friday, September 09, 2022
Torah: Deuteronomy 21:10-25:19
Haftarah: Isaiah 54:1-10
Saturday, September 10, 2022

NOTE: I am using a Siri shortcut to parse the output, and will be happy to provide more info, if someone is here to read that.

EDIT: in fact, many parameters make no difference at all whether they included in the URL, excluded, and no matter what value is passed to them (on/off etc).

https://github.com/aepshtin/test-hebcal-dx

You have a problem with using your own data on your website. For 2022-10-15 the "leyningmaftir" from your REST API is Numbers 29:26-29:31. This is the standard maftir for Chol Hamoed Sukkot, and is the same as Chabad's: https://www.chabad.org/parshah/default_cdo/aid/137613/jewish/Sukkot.htm

However, your website https://www.hebcal.com/holidays/sukkot-2022?i=on lists Numbers 29:29-34. Have no idea where this comes from other than it being the 4th aliyot of Hoshana Raba, the next day.

And, interestingly, your puzzling concatenation field, "leyningtorah" on that day shows: Exodus 33:12-34:26; Numbers 29:17-22, 29:20-25, 29:23-28, 29:26-31, 29:29-34 Which is not at all what is read. But the final 8 characters: "29:29-34" are the same as the odd "leyningmaftir."

Hebcal is great.

I note that the various repos in the hebcal organisation are under a variety of licences.

I would like to use hebcal in my website's frontend but under the GPL this may only be possible if my website is open source, including the original unbundled js files. For this reason relatively few NPM packages are GPL. There is some conflicting advice at https://softwareengineering.stackexchange.com/questions/181082/can-i-use-a-gpl-licensed-piece-of-javascript-on-a-commercial-website and https://opensource.stackexchange.com/questions/4360/what-are-the-implications-of-licensing-a-javascript-library-under-gpl

Please will you confirm if this package can be used by a website that is not open source?

https://www.hebcal.com/sedrot/vaetchanan

V'etchanan, triennial year three, aliya #3 -- displays "12 p'sukim" but I only count 9. Am I counting wrong?

Shavua tov.

The flags dict is defined as a typescript const enum. This can lead to difficulties:

https://www.typescriptlang.org/play?target=9&jsx=0#code/JYWwDg9gTgLgBAbzgMwDYEMDmBnOBfFKCEOAcgAEALAUwCMBjdVAenumtIG4AobtgO2zxkcALxwA8rQBW1ejAB0yIiACi-GFGDVsACimz5C6hq07d3OFbjNmccjGwBaagA8wcmC6hEoALjgAd0p0GGoAN2ooS2s0LGxuAEpEnj4IQQhUagVUCExdZBTeAWxM7Nz8uJwFAGEACQBBAHFEoA

Input:

import { flags } from '@hebcal/core';

const f = Object.fromEntries(Object.entries(
    // @ts-expect-error: whatever
    flags
));

console.log(f);

console.log(flags.CHAG)

Output:

const f = Object.fromEntries(Object.entries(
// @ts-expect-error: whatever
flags));
console.log(f);
console.log(0 /* flags.CHAG */);
export {};

The correct flag for CHAG is 1. Code relying on flags.CHAG and thus-compiled will fail. I worked around this by copying the flags table into my code. A better solution would be to export the table as an object

export const flags = {
  // ...
} as const;

An even better solution would be to vend predicates instead of bitmasks.

Besoros tovos

Missing flags like mask 13 for Simchat Torah

According to the ReadMe:

hDate.getMonthName() ⇒ string

Returns untranslated Hebrew month name.

Since it returns the English transliteration for the Hebrew month, either the docs should be:

Returns the English transliteration of the Hebrew month (without regard to locale).

Or the function should be changed to return the Hebrew month in Hebrew.

hi, i have wrote the following code:

import {MoladEvent, Locale, HebrewCalendar, months, HDate, Location, Event, ParshaEvent, Zmanim} from '@hebcal/core';


const options = {
  year: parseInt(year),
  start: new Date(2023,9,14),
  end: new Date(2023,9,14),
  isHebrewYear: false,
  candlelighting: true,
  location: Location.lookup('Jerusalem'),
  sedrot: true,
  omer: true,
  shabbatMevarchim: true,
  molad: true,
  il: true,
  locale: 'he'
};


const events = HebrewCalendar.calendar(options);

for (const ev of events) 
{
  const hd = ev.getDate();
  const date = hd.renderGematriya(true);
  console.log("1: " + date);
  console.log("2: " + hd.getDay());
  console.log("3: " + ev.render('he'));  
  }

}

i have hard coded the date to the date that there is a MEVARCHIM and MOLAD

the outcome of this code is that when it get to the MOLAD event, although i specified 'he' in the rendering the outcome of the MOLAD is in English:

3: Molad Tishrei: Fri, 49 minutes and 0 chalakim after 5:00

I find this module to be extremely helpful for a project I'm working on, but why are hours ignored when creating a new HDate? Isn't it pretty important to know if an event if before or after sunset?
I originally posted this issue in hebcal-js, but then someone pointed me to this newer version of the module, so I'm posting it here, too.
As an aside, how come there's no mention of this es6 version on the original js port's readme?

1. This code shows "Chanukah: 1 Candle" for the 24th of Kislev, isn't Chanukah starting at the 25th?
2. Is there any way to filter out the holidays that aren't relevant to me like Chag HaBanot, Rosh Hashana LaBehemot etc.?
   Thanks

  const events = HebrewCalendar.calendar({
    year: 5784,
    isHebrewYear: true,
    noModern: true,
    mask: flags.MINOR_HOLIDAY
  });

Created an issue on the wrong project, so reposting here.

Original ticket: hebcal/hebcal#213

hello.
i have searched for option to get data for few Shabbat in advance by entering dates "from" - "till".
but its not working.
on the week days it works with choosing dates though.
why ?

Shalom uvrachah

Hebcal's zmanim calculations diverge significantly from the printed luchot commonly sold in jerusalem

without descending into a lengthy discussion of the halachic merits of the various approaches, it would be helpful to many gabbaim (and gabbai-affiliated nerds) to provide computed times which accord more-or-less with "the luach i bought in the shop"

my personal ignorance knows no bounds, nonetheless my cursory surveys of the relevant sugyas as well as the code suggest to me that if the elevation in jerusalem, or better yet at a given lat/long were taken into account in @hebcal/solar-time, then it would be possible for the gabbai-affiliated to soothe the hesitations of the gabbaim themselves where @hebcal/core integrations are concerned

Thank you for your consideration

besoros tovos

For example I want a way to get the following string (in hebrew)

parshas vayijra shabbos chol hamoed

I had this exact functionality at some point with a single function without constructing the string myself, but I don't remember how I did it

https://github.com/hebcal/hebcal-es6/blob/d6bcd85d7963c5a316370f1eb3d0431d6c354831/hebcal.d.ts#L31C25-L31C25

    export class Event {
        /**
         * Constructs Event
         * @param date Hebrew date event occurs
         * @param desc Description (not translated)
         * @param mask optional holiday flags
         * @param attrs
         */
        constructor(date: HDate, desc: string, mask?: number, attrs?: any);
        getFlags(): number;
        getDesc(): string;
        basename(): string;
        url(): string;
        getDate(): HDate;
        render(locale?: string): string;
        renderBrief(locale?: string): string;
        getEmoji(): string;
        observedInIsrael(): boolean;
        observedInDiaspora(): boolean;
        observedIn(il: boolean): boolean;
        clone(): Event;
        getCategories(): string[];
        readonly date: Date;
        readonly desc: string;
        readonly mask: number;
        readonly emoji?: string;
        readonly memo?: string;
    }

readonly date: Date should instead be readonly date HDate.

Looks like the static monthNames inside of greg.js (and possibly others) cause problems for webpack and other older JS systems. Let's move any of these out of the class and make them private file-level const.

Module parse failed: Unexpected token (180:20)                                                                                                       friendly-errors 14:42:08
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|    * @type {string[]}
|    */
>   static monthNames = ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December'];
|
|   /**

daf Yomi yerushalmi

Is there a possibility of creating a daf Yomi yerushalmi subscription calendar for the new cycle that just began?

The 11th cycle of Yerushalmi Yomi began on Nov 14, 2022 / 20 Cheshvan 5783.

Looks like we don't have a daf on Yom Kippur and Tish'a B'Av but otherwise similar in cycle structure to the Bavli