Comments (13)
Feel free to submit a pull request and a means of testing and I am happy to merge this into the project.
from d4.
PR:
#15
from d4.
BAM! https://www.npmjs.org/package/d4
thanks @jefffriesen
from d4.
sweet. Testing things on my end now.
from d4.
Was looking at this with @jefffriesen, looks like this won't quite do it, since each of the files in src refer to d4 as though it's a global... if you'd consider it, we could look at moving a few things around so it refers to the correct d4 object when built.
from d4.
@tgriesser @jefffriesen that sounds great to me as long as the composabilty of the library remains. Honestly, I'd like to refactor base.js into a series of smaller modules at some point too so maybe this would be a good first step. So consider this +1 from me!
from d4.
Any progress on this? I'm hoping to use d4 with browserify in a project.
from d4.
@nsonnad happy to consider pull requests for this feature, but i've been working on other aspects of d4 at the moment.
from d4.
Cool, I'm hoping to prepare a PR for this. Do you have some guidance as to how to refactor base.js
(or modularize other parts of d4)? In trying to remove the dependency on d4
as a global I'm having to pull things apart quite a bit, but I want to make sure I'm following what you envisioned.
from d4.
@nsonnad sorry for the late reply I wanted to think it over before responding. In general the only thing I'd like to ensure is that at some point we can pull the requisite parts away from base.js and make it a plugin style model. Right now d4 is a ball of features and parsers but as things grow i expect users will want to just choose the charts they are interested in. This was my main approach in claiming a global namespace early on. If you can continue to support this long term goal with the reorganization needed to make it work inside browserify I am all for it! Please let me know if you need any help, or have questions about the codebase I am more than happy to ride shotgun on this with you.
from d4.
I've made a browserify branch now off of master https://github.com/heavysixer/d4/tree/browserify
I plan on working on this now. @nsonnad if you have anything you've been working on that you'd like to contribute let me know.
from d4.
Thanks @heavysixer. I did plan on working on it at some point in the next couple of weeks. I've done some initial work but it was mainly just me orienting myself with the library, nothing too helpful.
I'll keep an eye on the progress in that branch and suggest ways I can help out as you go. How does that sound?
from d4.
@nsonnad this sounds perfect, thanks for doing that.
from d4.
Related Issues (20)
- Waterfall charts do not respect min/max of the chart domain.
- Dual-axis capability on a basic chart HOT 10
- Transitions broken on the donut chart example HOT 1
- Scales shouldn't auto-nice without an option to prevent it HOT 1
- Method to change stack order of elements HOT 7
- Better series indexing HOT 10
- Add Padding method make distinct from Margin HOT 8
- Dual-axis capability breaks when using groupedColumnSeries HOT 6
- Negative label values are not displayed properly
- Refactor as node module HOT 7
- API or documentation for scale nicing HOT 9
- Attempt to make the svg more responsive to resizing
- d4.js:1172 Uncaught ReferenceError: d4 is not defined HOT 3
- License Missing HOT 1
- Throws reference error when using Browserify (assuming will also throw error with other bundlers?) HOT 2
- Cannot read property 'ordinal' of undefined HOT 12
- missing [week,hour,0] data result wrong graph for punch-card example
- [enhance] add line for punch-card
- wrong order punch-card data result wrong graph for punch-card example
- Example links in documentation are broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d4.