Giter Club home page Giter Club logo

Comments (6)

heavysixer avatar heavysixer commented on July 20, 2024

yes I think the error goes even further back because:
https://github.com/heavysixer/d4/blob/master/src/features/grouped-column-series.js#L82-L97

assumes you'll only have a dimension of x or y. We probably need to set this to use the scaleId or yScale accessor like we did in the previous fix.

https://github.com/heavysixer/d4/blob/master/src/features/x-axis.js#L97-L99

from d4.

nsonnad avatar nsonnad commented on July 20, 2024

Hey @heavysixer, in case you haven't gathered yet @yanofsky and I are working together and using d4 in our project. Have you started working on the dual-axis groupedColumnSeries issue? Would you like us to have a go at it?

from d4.

heavysixer avatar heavysixer commented on July 20, 2024

hey @nsonnad i figured you two were in cahoots some how given the branch and fork tree. I would love for you to take a crack at it, I've been slammed with other work this week. I am happy to help you suss out where this bug is exactly, and I don't think it should take too long once you get the feature pointed at the correct scale I just don't have time to look at it yet.

Any help is greatly appreciated :) !

from d4.

nsonnad avatar nsonnad commented on July 20, 2024

Have a PR for this, #37

from d4.

heavysixer avatar heavysixer commented on July 20, 2024

@yanofsky @nsonnad thanks again for this PR. One quick question, i know you are working on a project using D4, is it now or will it be open to the public? I would very much like to see what the two of you have cooked up.

from d4.

yanofsky avatar yanofsky commented on July 20, 2024

yup!

We should be open sourcing it in the next few weeks

from d4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.