heavyionanalysis / qnanalysis Goto Github PK

Current QnAnalysis project structure:

QnAnalysisCorrect:

• Conversion of AnalysisTree to Q-vectors (automated + hard-coded user interference)
• QVector corrections: YAML config

QnAnalysisCorrelate:

• Building QVector correlations: YAML config? Hard-coded
  User-space where user builds correlation
  Static registry: string identifier + object: YAML config
  Common:
  QxQx() - string representation
  QyQy()
  ...
  YAML config: problem: polymorphism:
  dynamic (= runtime, configurable) set of QVectors

QnAnalysisObservables:

• Building observables from QVectors correlations
  naming convention? YAML config?

not yet compatible

Hi,

My installation throws errors during the compilation:

QnAnalysis/build/_deps/qntools-src/include/base/QnTools/DataContainer.hpp:407:12: error: no member named 'set' in namespace 'std'

and

QnAnalysis/src/QnAnalysisCorrelate/CorrelationTaskRunner.cpp:54:14: error: aggregate ‘TObjString container_meta’ has incomplete type and cannot be defined

Proposed solution:
add #include <set> in DataContainer.hpp

@eugene274, can you please add alignment correction to yaml config?

-- Set runtime path of "QnAnalysis/install/lib/libQnAnalysisBase.so" to ""
CMake Error at src/QnAnalysisBase/cmake_install.cmake:69 (file):
  file INSTALL cannot find
  "QnAnalysis/src/QnAnalysisBase/QnAnalysisBase/Axis.hpp": No such
  file or directory.
Call Stack (most recent call first):
  src/cmake_install.cmake:47 (include)
  cmake_install.cmake:76 (include)

I believe the issue is in src/QnAnalysisBase/CMakeLists.txt
Because of the 'list(TRANSFORM HEADERS PREPEND QnAnalysisBase/)'

Possible soultion:

set(HEADERS1 ${HEADERS})
list(TRANSFORM HEADERS1 PREPEND QnAnalysisBase/)
ROOT_GENERATE_DICTIONARY(G__QnAnalysisBase ${HEADERS1} LINKDEF QnAnalysisBaseLinkDef.hpp)

At least now make install finishes without errors.
The insrtall/include now is:

is this correct?

During make install I encounter an error:

CMake Error at src/QnAnalysisBase/cmake_install.cmake:64 (file):
file INSTALL cannot find
"/home/peter/Soft/QnAnalysis/src/QnAnalysisBase/QnAnalysisBase/Axis.hpp":
No such file or directory.

It seems that the path to the file Axis.hpp is wrong.

Specification of YAML presumes inheritance:
https://dmitryrck.com/how-to-use-inheritance-in-yaml-files/

Base data structures may help to define many of similar objects.

Dear @eugene274,

The correction step works ok with Psi-vectors, but correlations build incorrectly. The histograms of the psi-components in output after the correction step seem to be alright, but correlations are either zero-filled or filled with incorrect values.

Compilation error during make. (with root 6.24.06)
It seems to be due to TDirectory::operator= which is deleted.

QnAnalysis/src/QnAnalysisObservablesEK/na61/na61.cpp:352:31: error: use of deleted function ‘ROOT::Internal::TDirectoryAtomicAdapter& ROOT::Internal::TDirectoryAtomicAdapter::operator=(const ROOT::Internal::TDirectoryAtomicAdapter&)’
  352 |                  gDirectory = cwd;

Solution:
Use TDirectory* cwd = gDirectory; everywhere in the file.

edit:
Suggestion of ROOT team to use TContext
https://root-forum.cern.ch/t/tdirectory-operator-is-deleted/48064

It is important to save separate file with QA plots to be able to merge QA-s and see pictures with full statistics without merging of data

This is fixed in QnTools, however, the cmake_modules/QnTools.cmake is not tracking master but an older tag.

[100%] Linking CXX executable QnAnalysisCorrect
/usr/bin/ld: CMakeFiles/QnAnalysisCorrect.dir/QnCorrectionTask.cpp.o:(.rodata+0x2b8): undefined reference to Qn::DataContainerHelper::ToErrorComparisonGraph(Qn::DataContainer<Qn::Stats, Qn::Axis<double> > const&)' /usr/bin/ld: CMakeFiles/QnAnalysisCorrect.dir/QnCorrectionTask.cpp.o:(.rodata+0x2c0): undefined reference to Qn::DataContainerHelper::ToBootstrapScatterGraph(Qn::DataContainer<Qn::Stats, Qn::Axis > const&)'
/usr/bin/ld: CMakeFiles/QnAnalysisCorrect.dir/QnCorrectionTask.cpp.o:(.rodata+0x2c8): undefined reference to `Qn::DataContainerHelper::ToTMultiGraph(Qn::DataContainer<Qn::Stats, Qn::Axis > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, Qn::DataContainerHelper::Errors)'

cmake version 3.17.4
gcc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1)
ROOT Version: 6.22/02

Dear @eugene274,

Please fix the initialization of psi-type vectors. Part of the code corresponding to this functionality is marked as "todo". That is why the correction step doesn't work properly.
Please, check also correlations with psi-vectors. They are empty after the correlation step.

Requested by Peter

Dear @eugene274,

I faced a problem with QA histograms in the Correction step. When setting the axis to the QA histogram given by bin edges, it doesn't work properly. The range of the axis is divided by the number of bins of equal width instead of setting the bins given by the user.
For example, I tried to set this bin edges to the QA histogram:
[0, 0.29375, 0.35625, 0.41875, 0.48125, 0.54375, 0.61875, 0.70625, 0.81875, 1.01875, 2.0]
Instead I got:
10 uniform bins from 0 to 2.

I hope you can sort it out soon,
Thank you in advance!

Segmentation fault is happening when I try to perform QnAnalysis with 2 input filelists. Problem line is here: https://github.com/HeavyIonAnalysis/AnalysisTree/blob/master/infra/TreeReader.hpp#L144

"Manual" debugging shows that the problem seems to be corresponded with "RecParticlesMcPid" branch in friended tree.

Log-file (log.txt
log.txt
) is attached.

Conditions:
gcc 9.1.0
ROOT 6.20.08
Setup-file: https://github.com/lubynets/QnAnalysis/blob/lambda/setups/lambda-analysis-config.yml
First filelist: /u/lubynets/fst_prim.list, tree name "aTree"
Second filelist: /u/lubynets/fst_sec.list, tree name "cTree"