he9qi / ember-cli-deploy-fastboot-s3 Goto Github PK

It'd be nice to enable revision activation using the same pattern as Ember CLI Deploy S3 Index.

• Use Ember CLI Deploy Display Revisions to find the revision key in the CLI.
• Activate the desired revision via ember deploy:activate --revision <revision_key>.

References

• ember-cli-deploy-s3-index/index.js
• ember-cli-deploy-s3-index/lib/s3.js

Trying to run ember deploy {{env}} and it complains about this.

- Missing required config: `bucket`
Error: Missing required config: `bucket`
Error: Missing required config: `bucket`
    at Class.ensureConfigPropertySet (/Users/lpotter/Development/Apps/mashbo/node_modules/ember-cli-deploy-plugin/index.js:57:13)
    at Array.forEach (native)
    at Class.configure (/Users/lpotter/Development/Apps/mashbo/node_modules/ember-cli-deploy-plugin/index.js:39:19)
    at Object.fn (/Users/lpotter/Development/Apps/mashbo/node_modules/ember-cli-deploy/lib/tasks/pipeline.js:93:21)
    at Pipeline._notifyPipelinePluginHookExecution (/Users/lpotter/Development/Apps/mashbo/node_modules/ember-cli-deploy/lib/models/pipeline.js:173:19)
    at tryCatch (/Users/lpotter/Development/Apps/mashbo/node_modules/rsvp/dist/rsvp.js:538:12)
    at invokeCallback (/Users/lpotter/Development/Apps/mashbo/node_modules/rsvp/dist/rsvp.js:553:13)
    at publish (/Users/lpotter/Development/Apps/mashbo/node_modules/rsvp/dist/rsvp.js:521:7)
    at flush (/Users/lpotter/Development/Apps/mashbo/node_modules/rsvp/dist/rsvp.js:2373:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
Pipeline aborted

Hello, I have found a bug, during the activation of revision it may fail with REVISION NOT FOUND if number of dist archives on S3 bucket if more than 1000(it may be more than 1000 in staging environment for example). This related to limit of ListObject method of AWS API: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjects.html
The listObjects function doesn't check IsTruncated value to fetch full bucket listing, so it is limited to 1000 entities. I believe it is not mandatory to fetch all revision from bucket and then check it target revision exists there, you can just check if target revision dist archive is present in bucket, I think it would be more effective.

Hello!

It looks like a recent change in #9 breaks first time deploys. This line fails https://github.com/he9qi/ember-cli-deploy-fastboot-s3/blob/master/index.js#L136 because the deployInfo has not yet been uploaded.

cc @jheth

       |  +- fastboot-s3
       |    - preparing to activate f8a03a2c01e22c297830af7558808cfa
       |    - NoSuchKey: The specified key does not exist.
       |    - NoSuchKey: The specified key does not exist.

Hi there, thanks for this great lib!

Would you mind pushing the tags to github, so we can see the code for each version?

git push --tags

This addon works well when used in conjunction with the ember-cli-deploy-s3 plugin so that the assets can be served from an S3 bucket or CDN instead of the fastboot server. However, it does require fingerprinting to be setup correctly.

It should be possible to support filePattern and fileIgnorePattern config options.

The goal would be to prevent serving fonts, styleshseets and non-fastboot JS from the server.

I need to look into this a bit further, but wanted to get some initial ideas down.