hbussell / django-slimmer Goto Github PK

The slimmer currently strips out server-side include directives. See:

http://wiki.nginx.org/NginxHttpSsiModule

A one-character change to the html_comments_oneline regex would fix this. See:

http://gist.github.com/334240

The current regexp used to strip one-line HTML comments has two bugs:

1. It's called after the whitespace stripping regexp, which means that every comment is considered to be one line and is therefore stripped. This is confusing if you've ready the source and expect multiline comments to stay intact.
2. Due to the above all Internet Explorer conditional comments will be stripped, which are often used for things like compatibility stylesheets. I chose to fix this by changing the regexp to not match '<!--[', which is the conditional comment start, but fixing both problems by swapping steps 3 (one-line comment strip) and step 2 (stripping whitespace between tags) will leave multi-line conditional comments (which most tend to be) intact. Arguably both would be a good idea.