hbasheer / jaleb Goto Github PK

Hey @hbasheer, for the example that you've listed in the README, the price doesn't show up at all. And if you use the 'http' version of the url, the example doesn't work. I had to convert it to 'https' for the example to work.

Hi @hbasheer,

Very happy to see that you have continuing from where the fletcher gem left off! I was wondering how to make this gem more robust, and wanted to get your thoughts on the following -

1. There was this thread in the original fletcher gem about product information fallbacks. Essentially, it talks about including OG product information, Microdata and LD format. The advantage of doing this would be that you wouldn't need to add site specific scraping rules, but instead rely on a few standards and make it work for a whole host of ecommerce sites (like Shopify, or Squarespace hosted sites).
   What do you think about including it in Jaleb?

2. Also, the 'Amazon Deets` gem has a more robust fallback strategy for Amazon products. Your thoughts on maybe including them here? https://github.com/briandamaged/amazon_deets/tree/master/lib/amazon_deets

Thank you!