havocframework / modules Goto Github PK

Thanks for the template for InlineExecute. Funnily enough I started expanding the framework yesterday and have mostly nailed down the function to pass to python scripting engine.

When passing the original script:

def arp( demonID, *param ):
    TaskID : str    = None
    demon  : Demon  = None

    demon  = Demon( demonID )
    TaskID = demon.ConsoleWrite(demon.CONSOLE_TASK, "Tasked demon to lists out ARP table")

    demon.InlineExecute( TaskID, "go", "Modules/SituationalAwareness/ObjectFiles/arp.x64.o", "", False )

    return TaskID

Havoc returns:

Traceback (most recent call last): File "<string>", line 48, in arp TypeError: argument 5 must be str, not bool

Changing the script to:

demon.InlineExecute( TaskID, "go", "Modules/SituationalAwareness/ObjectFiles/arp.x64.o", "", "" )

Fixes the problem. Will be happy to share the rest of the scripts with the community once finished.

NOTE: Ignore me, just pulled the latest version and it is working without any changes. Please close.

Hey,

Thanks for looking into this.

Importing InvokeAssembly adds command dotnet execute but running assembly as per example does nothing. Here is the command line:
dotnet execute /home/pwnie/Havoc/Client/Assemblies/Rubeus.exe

Successfully imported script.

Limiting the results for ldapsearch is currently not possible. When trying something like:

ldapsearch "(objectCategory=computer)" "*" "1"

There is an error:

Traceback (most recent call last):
  File "<string>", line 903, in ldapsearch
  File "<string>", line 892, in ldapsearch_parse_params
  File "<string>", line 46, in adduint32
struct.error: required argument is not an integer

This is because result_limit is a string and not an int:

A possible fix would be params[ 2 ] -> int(params[ 2 ]) in ldap_search_params (tested it). I'll create a quick PR.

Hey, as per the title nanorobeus when doing a kerberoast on line 330 has the following:

arg1 = param[ 1 ]

This causes it to fail when launched with 1 arg per the help file, changing it to:
param [ 0 ]
Enables it to successfully run (the output is incorrect but I believe that's another issue).

In the psexec module, https://github.com/HavocFramework/Modules/blob/main/Jump-exec/Psexec/psexec.py , on line 31, the following check is performed:
if len(param) < 3:
However I think it should be set to either < 4 or <=3, as the later code expects to item to have 4 values (Line 37 calls param [ 3 ]).

I've done some testing and this appears to work if changed per the described. Thanks for a great project!

I would like to know, after using the template to create a module, what would be the next step to use it in an agent.