hatrison / pacmangame Goto Github PK

1. Terrible code:

   PacManGame/src/js/Enemy.js

   Lines 100 to 110 in 811b924

   	isCollision(pacman) {
   	const size = this.size / 2;
   	if (
   	this.x < pacman.x + size &&
   	this.x + size > pacman.x &&
   	this.y < pacman.y + size &&
   	this.y + size > pacman.y
   	)
   	return true;
   	else return false;
   	}

   
   See following:

  isCollision(pacman) {
    const size = this.size / 2;
    const { x, y } = pacman;
    const x2 = this.x + size;
    const y2 = this.y + size;
    return this.x < x2 && x2 > x && this.y < y2 && y2 > y;
  }

2. Use collection instead of switch/case:

   PacManGame/src/js/Enemy.js

   Lines 83 to 93 in 811b924

   	switch (this.direction) {
   	case directions.up:
   	this.y -= this.speed;
   	break;
   	case directions.right:
   	this.x += this.speed;
   	break;
   	case directions.down:
   	this.y += this.speed;
   	break;
   	case directions.left:

3. Multiple nested loops and deeply enclosed if-statements are detected.
4. Multiline if-conditions are not readable
5. Hardcoded magic numbers

Need interview or refactoring to pass exams