harvard-dce / dce_lti_py Goto Github PK

This package is excellent work. I even see that you've used my only contribution to oauthlib in the form of SignatureOnlyEndpoint. I'd like us to work together to provide a common direction for this package. Some things that I'd like to see, and I'd like your feedback on:

• Change the name of the package to lti. AFAICT, there's no package called lti on PyPI, so this would make a great candidate to take that name. It might also be a good time to remove some deprecations.
• Add another method that allows for the params to be signed without creating an OAuth request. My use-case is that I'm creating a simple LTI launcher, similar to, but a bit more configurable than, https://github.com/instructure/lti_tool_consumer_example. I'm interested in writing this, though I can't commit to any timeframe for it.
• Shorten some of the class names. For example, perhaps ToolProvider and ToolConsumer can just be Provider and Consumer. I'm not 100% convinced that's best, but I like short names in general.
• Python 3 compatibility. It may already exist, but it's not in the test matrix. I'm happy to get that going.
• Docs. It'd be good to have some sphinx documentation. I may also be able to put some time into this.

I'd be willing to help maintain the project on PyPI and GitHub, especially if it were possible to have admin access to the repository so that I can add code testing and review tools. I'd be happy to get a wheel up on PyPI, I've done that a couple times before.

If you don't think collaborating here is a good idea, we could set up another org for this, or I can fork, or whatever. If we can work together that'd be ideal, of course, but I'd love your feedback on what the best way to help drive this forward would be.

Would love to have 0.7.4 on PyPI!

I am using this package to create a tool consumer for one note lti. I am passing all the correct paramters and also the generated launch data seems correct but one note lti gives below error:
"The consumer key or secret isn't correct. You need to register your LMS on the www.onenote.com/lti site, and you will be given the correct values."

I tried using those same consumer key and secret key in this example for one note lti and it's working fine. https://github.com/instructure/lti_tool_consumer_example

I think there might be some problem with OAuth1 signature request. Please help.