Comments (13)
Oops, here's my repo: https://github.com/aaronlerch/prelaunchr/tree/rails_4
from prelaunchr.
Sorry about the delay in getting back to you. Will take a look over the next week or so and figure out what the implications would be. I'm all for upgrading to Rails 4, just don't want to leave a bunch of people in the dust. Might make sense to do a final tag with Rails 3 and then have master be Rails 4.
from prelaunchr.
😎 no worries!
from prelaunchr.
It's been about 3 weeks so I figured I'd circle back around and see how you want to handle this? Thanks!
from prelaunchr.
@aaronlerch since there are no tests, and since we will still have to support this project, but rails 4 is a useful addition lets do this: let's merge your changes into a branch that is not master called rails_4. If you could create two PR's, one that merges your changes into a branch called rails_4 on our repo, and one to update the README on our master letting people know there is a Rails 4 version at that branch would be great.
from prelaunchr.
Sounds like a plan!
from prelaunchr.
i submitted a PR with some tests in case that helps with this one
from prelaunchr.
Hi @danielschwartz
I know you are busy, but can someone commit these pull requests, and also start committing the other pull requests, they are starting to pile up. I would like the fork the project, and especially use the Rails4 branch. Please add me as a contributor if you do not have the time. Thanks
from prelaunchr.
@ckhatton we've unfortunately abandoned supporting this project. We'd be happy for you to fork it to a separate repo and become the owner of it, as long as you remove our assets from it.
We just don't have time to support this specific project in addition to all our other open source endeavors. Sorry!
from prelaunchr.
@danielschwartz Okay that is fine - I will fork it and see if I can take on the pull requests (which I have never done and not sure is possible to a forked repo) 🎱
from prelaunchr.
I've done it over at https://github.com/wardpenney/prelaunchr
I need to remove the assets, but it is Rails 4.2, Ruby 2.2.0
from prelaunchr.
@wardpenney Noice! 👍
Are you able to also add the outstanding pull requests?
from prelaunchr.
Done
from prelaunchr.
Related Issues (20)
- requirements for the prelaunchr? HOT 12
- Setting up mail? HOT 4
- A question about collected emails. HOT 3
- Responsive design HOT 1
- Precompilation fails HOT 7
- All in one HOT 1
- Source does not contain any versions of 'prelaunchr (>= 0) ruby' HOT 1
- config.ended HOT 1
- Filter is showing direct object name instead of email
- Working App??? HOT 7
- Getting to user dashboard after signup
- Bundle does not execute
- I just download The ruby the new one thus it go with that?
- Can I use this kind of concept in any other Language ? HOT 2
- How to change json version for prelaunchr? HOT 4
- Deployed on Heroku but It shows nothing in the browser... HOT 2
- 500 Error when visiting dev server HOT 5
- Mailchimp,mailgun,sengrid integrated in it?
- image precompile issues HOT 1
- Detecting visitor IP HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prelaunchr.