Comments (4)
We tend to run Rails apps on Heroku, in which case the routing layer acts as an HTTP proxy and request.ip is the IP of the proxy, not the user. The correct approach would be to use 'X-Forwarded-For' only if it is present:
request.env.fetch('HTTP_X_FORWARDED_FOR', request.remote_ip)
from prelaunchr.
^^ what this guy said
from prelaunchr.
@werkshy @danielschwartz I too faced similar situation using nginx and phusion passenger and had to tweak that piece of code. Would be great if this is changed in the code or add some reference in the README regarding this.
from prelaunchr.
I've made pull request #43 with solution.
from prelaunchr.
Related Issues (20)
- requirements for the prelaunchr? HOT 12
- Setting up mail? HOT 4
- A question about collected emails. HOT 3
- Responsive design HOT 1
- Precompilation fails HOT 7
- All in one HOT 1
- Source does not contain any versions of 'prelaunchr (>= 0) ruby' HOT 1
- config.ended HOT 1
- Filter is showing direct object name instead of email
- Working App??? HOT 7
- Getting to user dashboard after signup
- Bundle does not execute
- I just download The ruby the new one thus it go with that?
- Can I use this kind of concept in any other Language ? HOT 2
- How to change json version for prelaunchr? HOT 4
- Deployed on Heroku but It shows nothing in the browser... HOT 2
- 500 Error when visiting dev server HOT 5
- Mailchimp,mailgun,sengrid integrated in it?
- image precompile issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prelaunchr.