harness / gitness Goto Github PK

documenting suggestion from @afex on irc

add a section to the .drone.yml called setup

setup:
  - apt-get update
  - apt-get -y install libsqlite3 libsqlite3-dev

add these install scripts to the Dockerfile that we generate:
https://github.com/drone/drone/blob/master/pkg/build/build.go#L365

RUN apt-get update
RUN apt-get -y install libsqlite3 libsqlite3-dev

this would allow us to take advantage of Docker's layer caching. The build would use the cached image and avoid re-running install and setup commands. Saves time! If build script commands changed the cache would be invalidated and a new image would be generated.

question: how does this impact matrix builds?

It is currently possible to set "http" or "https" modes but where to put SSL certificate and key to make it work?

Hey guys,

thank you for this great project!
It would be awesome to have support for self hosted git repositories. Then drone would be the perfect solution for a enterprise project I'm working on and I could get rid of Jenkins :)

Cheers
Sebastian

cc @suguru

this was brought up in issue #75

when GitHub enterprise is run in private mode it prevents using git:// to clone public projects. This means every repository should be treated as a private repository -- using the git@ url and adding the ssh deploy key.

A couple of feature suggestions. They might be out of scope of the project but I thought I'd throw them out there.

Hostname/Port to container routing:

• Routes ports to containers
• For HTTP based protocols, also route on Host header
• Use wildcard DNS entry to allow host names to be dynamically generated for containers: branch.repo.org.mytestdomain.com
• Hostname pattern specified in .drone.yml
• Would allow external access to built projects without having the containers directly exposed
• In our case this would allow Selenium Grid nodes to test projects

Container persistence:

• Keep containers running until pull request is closed or build is superseded
• Used with hostname/port routing to
  • allow for manual checking of failures
  • allow for manual testing of pull request features/bug fixes

Is there a plan to integrate git repos like gitlab or any external source via public key?

Thanks for opensourcing this, it is really amazing!

After installing on Ubuntu 12.04 in virtualbox and setting up this repo: https://github.com/tax/testdrone I get the following error when a test is run:

dial tcp 0.0.0.0:4243: connection refused

This is my .drone.yml file:

image: python:2.7
script:
  - python test.py
notify:
  email:
    recipients:
      - [email protected]

Any idea what might be the problem?

How do I get this working with BB?

well, for the demo purposes would make sense (if you build on some public instance like drone.io).

Using latest deb-file and sqlite, after a user clicks the activation link and adds their password, the register post-handler fails during saving to db complaining about token not being unique.

2014/02/08 17:24:28 meddler.Insert: DB error in Exec: column token is not unique

One thing that bothers me with lots of cloud based build systems is that you cannot easily (to my knowledge) test the yml file before you commit. With Drone being based on docker, I don't see why you couldn't be able to do:

$ drone build

And locally run all of the scripts to make sure your configuration is what you want before you push your commits. Would this be possible? Any thoughts? Does this exist with other platforms?

I installed Drone on Ubuntu 13.04. Where is the log file located? I'm trying to use a HipChat notification function but I can not get any notifications on HipChat. I want to check a log file to understand what is wrong.

Wondering if this were suppposed to be /new/github.com instead of /github.com/drone/drone/settings?

also in github_link.html

I really like the idea of having a web service like drone.io to build projects.

I have still to find a service that provides ways to build D (http://dlang.org) projects with dedictated environments. So can drone be the first one please?

With some guidance on your ways of providing images, I'm likely able to provide an image myself. I guess a D image should be pulled into the drone/images repo right? Is this Repo also providing images for the drone.io web service?

When a non-admin goes to add a repository to their dashboard the first time they are (correctly) prompted to link their Github accounts. This always causes an error when the Github callback URL is invoked:

meddler.Update: DB error in Exec: column token is not unique

I believe this error is being thrown around line 85 of pkg/handler/auth.go but I won't be able to take a look until later tonight.

Cloning a large repository can take a long (build) time, we should do something like:

if [ -d $repository_path ]
  cd $repository_path && git fetch $remote && git reset --hard $branch
else
  git clone $repo $repository_path

after enter command make deps and make and done it successfully, but get errors while entering command make run.

➜  drone git:(master) make run
bin/droned --port=":8080" --datasource="drone.sqlite"
panic: template: _:51: function "eq" not defined

goroutine 1 [running]:
html/template.Must(0x0, 0x18883040, 0x189b5770, 0x0)
    /usr/local/go/src/pkg/html/template/template.go:284 +0x44
github.com/drone/drone/pkg/template.init·3()
    /home/howard/go/src/github.com/drone/drone/pkg/template/template.go:112 +0x26b
github.com/drone/drone/pkg/template.init()
    /home/howard/go/src/github.com/drone/drone/pkg/template/template.go:143 +0xad
github.com/drone/drone/pkg/handler.init()
    /home/howard/go/src/github.com/drone/drone/pkg/handler/util.go:112 +0x3f
main.init()
    /home/howard/go/src/github.com/drone/drone/cmd/droned/drone.go:202 +0x39

goroutine 2 [syscall]:

goroutine 51 [chan send]:
text/template/parse.lexSpace(0x188e6cc0, 0x84bb454)
    /usr/local/go/src/pkg/text/template/parse/lex.go:334 +0xc6
text/template/parse.(*lexer).run(0x188e6cc0)
    /usr/local/go/src/pkg/text/template/parse/lex.go:198 +0x39
created by text/template/parse.lex
    /usr/local/go/src/pkg/text/template/parse/lex.go:191 +0xe6
make: *** [run] Error 2

I'm splitting this into a separate feature request, given its popularity. The good news is there's a Go API that we can use as our base, however, it still lacks certain features like adding post-commit hooks and ssh keys (for private repos).

Is someone will to contribute to to the API and add these features?
https://github.com/plouc/go-gitlab-client

I'd volunteer, however, I have my hands full with this code base :)

I don't have access to GitHub enterprise, so I'm just guessing here, but this is what I think will need to get altered. It should be a relatively straightforward change ...

step 1: alter the github client to accept a custom url

NewClient(url, token)

https://github.com/drone/go-github/blob/master/github/github.go#L4
https://github.com/drone/go-github/blob/master/github/http.go#L44

step 2: alter our github oauth code (for linking accounts) to use custom access token and authorization urls:

var oauth = oauth2.Client{
    RedirectURL:      settings.URL().String() + "/auth/login/github",
    AccessTokenURL:   "https://github.com/login/oauth/access_token",
    AuthorizationURL: "https://github.com/login/oauth/authorize",
    ClientId:         settings.GitHubKey,
    ClientSecret:     settings.GitHubSecret,
}

https://github.com/drone/drone/blob/master/pkg/handler/auth.go#L43

Is it possible to configure drone so that if your project already has a Dockerfile, you can omit the script part of .drone.yml and rely on the Dockerfile to build the image?

I was hacking around, to make drone work with enterprise github, but I got really frustrated, because all imports are pointed to github repo? I am newbie in go, so is it recommendation from language?

This is low priority, but seems like drone doesn't like to tell user what is wrong. For example it only sends error messages like Not found or Unauthorized without context.

see our README.md as an example

I have to branches on my repository, develop and master. I pushed one commit on develop, drone built it, and all specs passed.

Next, I merged develop into master and pushed it to github. Drone is now building the master branch, current status is building, but if I click on the build, the previous build (from develop) is shown.

See the example below. This works as expected on drone.io and shows green text.

�[4mRunning "vows:all" (vows) task�[24m
�[32m·�[39m�[32m·�[39m�[32m·�[39m�[32m·�[39m �[32m·�[39m�[32m·�[39m�[32m·�[39m�[32m·�[39m  
  ✓ �[32m�[1mOK�[22m�[39m » �[1m8�[22m honored�[90m (0.129s)�[39m

Would be insanely useful. I'm working on one, would you merge?

Hi,

Is there any configuration so I can detect if I'm running pull requests or commits from master branch ?

I can see that deployment commands are not run if there is a pull request, but currently I cannot run capistrano deployment (I can't see any plugin for that).

Also, any chance to introduce IRC notifications ?

In /etc/drone.d/phpenv.sh you add home variable '/home/ubuntu/phpenv/bin'. I think that should be '/home/ubuntu/.phpenv/bin' (note the . in phpenv), as I'm always getting the following error:

/etc/drone.d/phpenv.sh: line 21: phpenv: command not found

Hi! It will be very good to have ability to split tests to N containers.
For languages like ruby, it will dramatically decrease execution time.
Is it possible?

Is what I can put in the repo's secure build params limited to just "key: value" pairs? I wanted to inject:

notify:
  email:
    recipients:
      - [email protected]

And the UI reports it saved it successfully, but if I navigate away from the page or peek at the repo's sqlite table it doesn't actually persist. Random entries like "somekey: foo" work fine though.

Need to understand how this impacts our badge implementation:
github/markup#224

Any changes required?

It seems like I have everything hooked up properly but somehow, my tests don't run.

Here's my .drone.yml:

image: ruby2.0.0
script:
  - bundle install
  - bundle exec rake db:create db:schema:load spec
services:
  - mysql
  - elasticsearch
  - redis
  - memcached

And a screenshot:

Any idea?

We should check for a minimum Docker version. The remote API changes between releases, and running an older version of Docker can cause panics and strange issues that are hard to debug.

I'd like to check when the app first starts. If Docker is not installed, or is out of date, we should not serve any of the standard handlers. Instead we should display a single page that gives instructions to upgrade.

Hey. I really want to get drone.io into stress environment and see how it's going, but current registration scheme gets in the way. Would you accept settings for enabling open registration in drone.io? Invites working great, but I feel like people just move along, when seeing login page without any hints, how get access.

Thank you for sharing this project again. It's wonderful!

How can someone submit a newer Haskell build? 7.4 is very outdated. A better target would be the 2013.2.0.0 Haskell Platform (https://index.docker.io/u/zsol/haskell-platform-2013.2.0.0/) which has upgraded to GHC 7.6.3.

There's also a new Haskell Platform on its way which might even include GHC 7.8.

Simply out of curiosity, what was the reason you chose not to go with one of the golang web frameworks?

I need this for testing one of my projects that's much like Docker. For now I've just forked Drone and switched it to run everything privileged, but I'm wondering what this would look like as a polished feature, so I can start putting together a PR.

For example, I'd expect pull-request-triggered builds to not run privileged, but I'm not sure what that means for the build. Perhaps it should set an environment variable so that the tests know to skip the ones that require it? Any other things to worry about?

Changing the role of a user to administrator fails with the following error:

Failed to update user data. meddler.Update: DB error in Exec: column token is not unique

Since drone needs to accept git hooks from github, it needs to be exposed on the public internet. It'd be nice if there were some protections on the login page:

• Two-factor auth
• Captcha after incorrect attempts originating from same IP or against same username
• IP whitelisting

Examples: feature/my-new-feature, hotfix/urgent-bug, release/1.0

Current examples show Heroku and Amazon deployments. It would be great if you can provide examples for the Rackspace too.

I'm wondering how would a .drone.yml would look if you'd want to test with multiple versions of Python, like for example, using Tox?

When I push to GitHub, nothing happens. If I go to debug the webhook on GitHub, it says there was a timeout. However, if I capture the request by adding a hook to another server and submit it directly to my Drone instance, it works just fine. Any idea what this could be? My first thought is firewall issues, but I haven't had a problem accessing my server from other locations before.

It would be great to be able to inject a pre-defined SSH key into containers.

As part of our build process, we pull down dependencies that are in private GitHub repos. Currently there's no (easy) way of accessing these repos from Drone. This could be resolved by adding the ability to generate an SSH key that's used by containers (copied to ~/.ssh/id_rsa), which we could then add as the deploy key for our dependencies.

I've got long verbose builds that have interesting output early on, but scrolling up just scrolls me down again. :)

When clicking on the Help link in the main navigation you get redirected to /help that returns a "404 page not found".

How can I know which commits the latest drone.deb includes without reinstalling Drone? The latest drone.deb includes merged PR as soon as possible?

If a build is still in progress and I visit the status page, my browser continually refreshes every second until the build is done.

cc @suguru @floatdrop

this was brought up in issue #75

the github url is currently hardcoded with an https:// prefix. Let's slightly change the design so that instead of github_domain we store github_url which is the scheme+domain, and remove the hard-coded https:// prefix.

we may also need a migration script for this, to change existing records from github.com to https://github.com

Hello, looks great!

If you've already set up your .deb building from deb-src, could you please put it up in a PPA? It would make installation much simpler, particularly for those of us who have our CI server configuration in puppet or chef scripts.

Cheers!
Michael