harisonmg / church-ims Goto Github PK

Description

raise causes control flow to be disrupted, as it will exit the block. It is recommended to check other conditions using another if statement, and get rid of else statements as they are unnecessary.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/harisonmg/church-ims/issue/PYL-R1720/occurrences/

Replace methods for getting parent/related objects with get_queryset in the following views:

• TemperatureRecordCreateViewTestCase

Add:

• district info
• district membership (including roles)
• district membership history

• Use a custom user model
• Password reset via email

• Use Django's RequestFactory instead of the test client. This will decouple URL resolution from the view functionality in tests
• Test each class-based view method independently

Similar blocks of code found in 4 locations. Consider refactoring.

https://codeclimate.com/github/harisonmg/church-ims/functional_tests/pages/components/forms/auth.py#issue_61feca777d14bd00010000a3

Description

Python will allow this, but if the overridden method is intended to be executed from an external code, you may want to reconsider this. Overriding a method without ensuring that both methods accept the same number and type of parameters has the potential to cause an error when the overriding …

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/harisonmg/church-ims/issue/PYL-W0221/occurrences/

• Reduce complex logic and "magic" context data by use of template inheritance

• Remove unnecessary URLs
• Update the URL scheme to be more "RESTful"

Add the search term to the pagination links to have paginated search results work properly

• Add methods to handle respective form inputs
• Split the forms module into a package

A parent-child relationship is created when the user checks the is_parent (I am the child's parent) check box. However, this relationship isn't available in the view tests

Description

A function, method or class is being redefined in the same scope. This would override the original definition, and doing this is strongly discouraged. Please verify that this is something that you intended to do.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/harisonmg/church-ims/issue/PYL-E0102/occurrences/

• Allow members to add their address(es)