haoranyu / chess Goto Github PK

In chessPiece/ chessBoard/ Empty.

Make them into package:

• models
• chessPieces

Get rid of the magic digit...

• I would break the function signature into two separate lines to improve readability
• As mentioned in discussion section, it would be better if maxIteration were -1 if you want to add possible Positions until you reach the end of the board (this way you can resize the board and the function will still work).
• How about "xDelta" instead of "toRight" and "yDelta" instead of "toUp". "toRight" gives me the impression that I should only go rightward.
• For this reason, the line "position = new Position(position.getRight(toRight).getUp(toUp))" is also a bit unclear. Especially because you can "getLeft" by adding a negative value.
• What if the Position class had a function "getRelativePosition( int xDelta, int yDelta)"?

Remove CP in front of the name.

Add an addRecord in chess board for recording.
Remove the original record adding logic in chessPiece class.

do not use gutters in constructor in subclass constructor

Implement Unit Test

After a move, if we check the king of other side. Then notify.

• A player wins when the opponent is in check and has no moves available. Your code has it so that a player wins if they capture the king (which should never really happen).
• Your code doesn't work; in particular, you don't prevent a player from moving a piece if that puts their own king in check.

Use Doxygen to replace Javadoc...

use the "for each" loop in java to iterate through a list. It will look like:

• for( Position possibleNextPosition : this.possibleNextPositions)
• This is because it conveys what is being done in a more clean manner, and involves less variables.