hakonrydland / a3-hr-garage Goto Github PK

Describe the bug

I thought the addon was just broken until five minutes ago when I finally saw the CBA settings, but only after launching a server with the mod running.

How to reproduce

1. Mount this addon.
2. Add the module and vehicles to a mission.
3. Load Eden.
4. Check here.
   
5. It's not here.
   
6. Launch multiplayer.
7. Configure addons.
8. THERE it is. But why is it only here? Also why is the base capacity set to zero???
   

Version

ArmA v2.10

Have you altered the code?

No

What i have changed

No response

Map

Takistan (CUP)

What server?

LAN Hosted

Time bug occured (Server time/UTC)

No response

Mods

N/A problem occurs even when running vanilla

Additional context

The whole wiki and README section of this Github seems severely outdated and poorly written. I strongly encourage going back and doing a thorough step-by-step rewrite.

The mod author seems to have written it with the assumption that whoever is adding this to their mission already knows a lot of what they're doing. You assume too much of my intelligence.

Describe the bug

Bug creates infinite laoding screen when accessing hr carage. RPT file included.

How to reproduce

Accessing hr carage trough vehicle its synced with
Arma3_x64_2022-10-23_18-09-45.zip

Version

Release 1.1.0.0:

Have you altered the code?

No

What i have changed

No response

Map

Stratis

What server?

LAN Hosted

Time bug occured (Server time/UTC)

No response

Mods

AAF in ALPAT	Steam	https://steamcommunity.com/sharedfiles/filedetails/?id=2252825701
Advanced Towing	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=639837898
AGC - Advanced Garbage Collector	Steam	https://steamcommunity.com/sharedfiles/filedetails/?id=1724884525
All-in-One Command Menu (Deluxe)	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=1893300731
Ares	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=421908020
Blastcore compiled by neetch	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=1158566432
CBA_A3	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=450814997
Enhanced Movement	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=333310405
HCC - High Command Converter 1.5.5	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=562920130
HR Garage	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=2600207268
MGI ADVANCED MODULES	Steam	https://steamcommunity.com/sharedfiles/filedetails/?id=1682280809
Reduced Haze Mod v3.1	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=1397683809
T-72 Turret Ejection (Lollipopping)	Steam	https://steamcommunity.com/sharedfiles/filedetails/?id=2383768184
Zeus Enhanced	Steam	http://steamcommunity.com/sharedfiles/filedetails/?id=1779063631

Additional context

No response

Describe the bug

ad

How to reproduce

a
MacrosGuide.pdf

Version

2.4.1

Did you alter the code

• #3

What i have changed

No response

Map

x

What server?

Private dedicated server, Private dedicated server with Headless client(s)

Mods

awda

Additional context

afda

Is the requested change related to a problem?

Look, I'mma be blunt, I am not a smart man. But I tried showing this to a few scripter friends of mine and they didn't really understand the README or Wiki either, so I'm starting to think it's outdated. It looks like this mod was originally created as just a script that you add into a mission, but now it is a full on module to simplify its use. This would be fine except that the instructions were never updated, and at face value, the mod seems broken.

It's not actually broken, but it won't work if you just follow the instructions on the workshop page.

This mod is extremely useful when you get it working, and will clear up a ton of clutter on my server with how many vehicles I let my players use, but that is all utterly worthless if I don't know how to use its features.

Describe the solution you'd like.

I strongly would encourage the mod maker to start from the ground up and give step-by-step instructions of how to install and configure this mod.

Part of that is already done on the Workshop page. But these instructions are VERY incomplete. If you follow the instructions on the Workshop page, you won't be able to use this mod at all and will assume the mod doesn't work.

Alternative soloutions

No response

Additional context

No response

Is the requested change related to a problem?

So right now, when this module is looked at in Eden editor, this is all we see.

This is all just the bare bones, and there's not even any module info explaining what it does and how it works. This is not very intuitive.

Describe the solution you'd like.

Here is an example from a different mod of how the module includes some of its parameters within the module itself.

If you could do something similar for this mod, things like the size of the garage, or a blacklist of certain vehicle classnames, a whitelist of vehicle classnames, vehicle classnames that the garage starts with, or other things formerly found in the config, it could make this module a lot more flexible.

It would also make the CBA options obsolete, and if you really want to get complicated with developing this, you might even be able to have multiple garages with different features scattered across the map. Maybe one garage only allows IDAP vehicles while another is military and won't allow civilian vehicles. Maybe you have a small garage of only 10 vehicles, and then a warehouse with 50 vehicles. Maybe you can exclude entire vehicle types like aircraft or boats. The possibilities from here get very substantial.

tl;dr start using the module itself to edit what it can do rather than CBA options

Alternative soloutions

Extra modules that can be synced to the core one, and these modules would affect different features of the core module.

Kind of like how the "Add vehicles" module is already a thing.

Is the requested change related to a problem?

a

Describe the solution you'd like.

b

Alternative soloutions

c

Additional context

No response

Is the requested change related to a problem?

Yes.

I thought the mod was broken because I followed the instructions on the workshop page and it didn't work unless I change CBA settings that I can only access when already running the server.

That is not very intuitive.

Describe the solution you'd like.

Make the default capacity infinite, or at least an extremely high number, so that players can actually use the addon out of the box. Server admins can always configure it to limit what it does later on if they so choose.

Alternative soloutions

If the capacity equals 0, recognize that as "There is no limit" in the code and skip the capacity check all together.

Additional context

Also, how does capacity increase work? That isn't explained anywhere.