hakobera / node-mecab-binding Goto Github PK

Hi, I am completely new to github, so I don't know where I should put that. Correct me if it was not the good place for it.

The issue is the node.surface data which is wrongly accessed (the string you're accessing does potentially not exist anymore at the time you're going back from javascript to C++ on the getter of Node.

Instead, I suggest of going through the whole node list and pulling the data. It costs a bit more at parsing time, but then everything is available in Javascript, no need to pull data back from C++.

(I changed tagger.cc / tagger.h to have a ParseToArray method which goes over the surfaces and features of each nodes and return the complete data)
Of course, in its current state it's pretty raw, and one may want to have more than just surface / feature, but at least you can access it correctly.

Edit: what's the best way for me to submit a change to the sources?