Giter Club home page Giter Club logo

webpub-viewer's People

Contributors

danielweck avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

Forkers

itmgr

webpub-viewer's Issues

Compatibility problem on Firefox

Observation

When I look at https://proto.myopds.com/?manifest=true&href=https://proto.myopds.com/manifest/mobydick.epub/manifest.json&document=https://proto.myopds.com/assets/mobydick.epub/main0.xml on the Mozilla Firefox browser (Ubuntu + Android), the content section have a height of 114px, so it's not possible to read the text.

Expectation

The content must fit the screen height.

Steps to reproduce the problem

Go to this URL on Firefox : https://proto.myopds.com/?manifest=true&href=https://proto.myopds.com/manifest/mobydick.epub/manifest.json&document=https://proto.myopds.com/assets/mobydick.epub/main0.xml

Add an access to the TOC

Observation

I don't find an access to the TOC (table of contents) on every page. (Note: perhaps this function match with non-fiction ebooks).

Expectation

Add an access to the TOC, besides the previous and next elements of navigation. (In viewer.js I guess, with the informations from the toc.ncx file on the EPUB.)

Steps to reproduce the problem

Try to go to a chapter without flip the different pages/chapters.

Service Workers do not work in sandboxed iframes

In order to test support in sandboxed iframes, a sandbox.html is available.

For security reasons, using a sandboxed iframe would be preferable but this currently kills the offline & pre-caching available in this app.

We'll need to investigate the situation regarding sandboxed iframes and if foreign fetch could be useful to fix this issue.

Getting the current iframe location

The current code base has the following behaviour:

  • if the iframe displays content from the same origine, we extract the location using iframe.contentDocument.location.href
  • if we can't get the location that way, we use iframe.src

When we can't use contentDocument.location.href, the app doesn't update next/previous actions if the user navigates to a new location within the iframe (following a link for example).

Is there any solution to this problem?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.