habel / tcpsockets Goto Github PK

Hi there, I'm not sure if you're aware of this, but there are multiple issues with this plugin. I'm not familiar with how one "comments" on an app so I thought I'd leave them here in an "Issue".

Throughout your documentation you refer to "TCPSocket" whether in the case of the .js file or the .java file, both seem to be named incorrectly, the actual files seem to be "TCPSockets.js" and "TCPSockets.java".

In the file TCPSockets.js your return statement looks like the following:

return PhoneGap.exec(successCallback,
failureCallback,
'TCPSocketsPlugin',
'sendMessage',
{
port: this.port,
host: this.host,
message: this.message
};

As you may notice, there is a bracket missing at the end just before the semi-colon. I'm also not sure if this is an issue but you seem to call the plugin by the name "TCPSocketsPlugin" when it is named "TCPSockets" in the java file.

Finally, in the TCPSockets.java file the first line of code reads that the package is listed under "com.habel.plugin.sockets" while in the documentation it seems to be listed as "com.habel.sockets" - are these correct?

Thank you for the time and effort put into the project as a whole, and have a good day!