Giter Club home page Giter Club logo

h-e-n-r-y / binance-marketmaker Goto Github PK

View Code? Open in Web Editor NEW
33.0 8.0 14.0 1.13 MB

Simple Trading Bot (still pre-alpha!). Connects to your binance account and tries to trade between 2 coins only accepting orders that will generate win. Needs https://github.com/binance-exchange/binance-java-api

License: The Unlicense

Java 65.54% CSS 4.25% HTML 24.13% JavaScript 6.08%
binance coins bitcoin translation trading bot cryptocurrency spring-boot spring thymeleaf

binance-marketmaker's Introduction

binance-marketmaker

Simple Trading Bot (still pre-alpha!). Connects to your binance account and tries to trade between 2 coins only accepting orders that will generate win. Needs https://github.com/binance-exchange/binance-java-api

Installation

Clone and build binance-exchange/binance-java-api:

I have forked the original api to be able to implement minor extensions easily. Also there is a major bug in the original API (regarding multi-tenancy) that is fixed in this version: https://github.com/h-e-n-r-y/binance-java-api branch henry-master.

cd ~/git
git clone https://github.com/h-e-n-r-y/binance-java-api
cd binance-java-api
mvn install

Build binance-marketmaker:

cd ~/git
git clone https://github.com/h-e-n-r-y/binance-marketmaker.git
cd binance-marketmaker/marketmaker
mvn install

Start

mvn spring-boot:run

Access your Marketmaker at http://localhost:8080/

First you must register a user and upload your api-key.

Install your binance-api-key

Create your API-Key here: https://www.binance.com/userCenter/createApi.html Edit your profile and fill in api-key and secret.

Access the H2-Database

Log in as sa (Password can be set in application.properties: db.sa.password). You are automatically redirected to the H2 Database Console. Use the JDBC URL jdbc:h2:~/h2/marketmaker.

Disclaimer

The app has lots of bugs and it's state is far from being ready! These bugs may lead to major loss! Be careful to understand the sourcecode before using it for dealing with high amounts of coins!

I appreciate comments, bugreports and suggestions for further development...

Thanks

Thanks, Christopher Downer, for sharing the coin icons. Check out his project here: https://github.com/cjdowner/cryptocurrency-icons

Henry

binance-marketmaker's People

Contributors

h-e-n-r-y avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

binance-marketmaker's Issues

Which file has the main decision making process?

Sorry, I know this is a bit lazy, I have crawled through the source and haven't found the "meat" yet. How do you decide if it is better to cancel your orders rather than leave them open? Where are you calculating spreads and taking into account fees? Thanks!

Enhancement Request

The following request might be too advanced for this project, but its worth a try. Maybe this can be part of a new project based on this project.

REQUEST:
Even though the project uses a basic strategy, this project seems very developed. One request would be to add a feature that monitors the "current" average price. For example, a user can set an option for the bot to take into consideration the average price of the last week (or) last couple of days (or) last couple of hours. Then the bot will be more independent.

EXAMPLE:
Currently, we could set a 1.30% difference of a price, but it is kind of based on luck.

With the feature, the bot will check the average weekly price (or) average daily price (or) average hourly price before each "buy/sell" or "sell/buy" cycle. Then it will adjust the price to better fit the average.

MORE ADVANCED REQUEST (NOT REQUIRED):
The user will be able to set whether the bot checks the average price each cycle or every other cycle, etc.

Unable to create a trade

Hello,
Thank you for your code contribution, I just deployed and tried your project and got the error at hiting button "Trade", Could you help me do a quick fix.

Thanks a lot,
Tuan Nguyen.

Internal Server Error
com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not deserialize value of type com.binance.api.client.domain.general.RateLimitType from String "REQUEST_WEIGHT": value not one of declared Enum instance names: [REQUESTS, ORDERS] at [Source: okhttp3.ResponseBody$BomAwareReader@1aeb72ab; line: 1, column: 77] (through reference chain: com.binance.api.client.domain.general.ExchangeInfo["rateLimits"]->java.util.ArrayList[0]->com.binance.api.client.domain.general.RateLimit["rateLimitType"])

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.