gwww / upb-lib Goto Github PK

It would be nice if releases appeared on https://github.com/gwww/upb-lib/releases.

When using a TCP connection to the PIM-IP from Pulseworx, the connection code always schedules a heartbeat check every 90 seconds. That works when using ser2tcp, but with such a direct connection the PIM does not provide any heartbeat traffic, so upb_lib constantly closes, reopens, and scans the whole network to assess state again every 90 seconds.

Things are even worse in Home Assistant’s UPB integration which uses added callbacks on the reconnection to establish link and scene integration each reconnection cycle.

Suggestion: allow heartbeat time to be overridden with a configuration option to the UpbPim() class. Or add it as a parsable flag on the TCP url, something like tcp://1.2.3.4[:port][?heartbeat_time=xxx[,name=val]*].

A tracking issue for the work suggested in home-assistant/core#65487.
At high-level, the plan would be to detect the presence of certain repeater devices in the UPE file, and use this information to automatically have the library set tx_count=2.
@gwww Any specific implementation advise before I start working on this?

• This library supports an integration in Home Assistant.
• The new pip resolver is more strict in resolving package version conflicts:
  http://pyfound.blogspot.com/2020/03/new-pip-resolver-to-roll-out-this-year.html#what-will-change
• To avoid future issues it would be good if this library would change its pinning to allow any higher version and just set a minimum version.

Thanks for your support of Home Assistant!