Giter Club home page Giter Club logo

postmates's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

postmates's Issues

sms package should probably be named termii

The sms package is more or less a wrapper or client for the termii service. I think it will be great if it is called termii.
This way it will be easy to return more appropriate error messages that are specific to termii.

So the package path will look something like this: github.com/gwuah/postmates/sms/termii

Later, other sms wrappers can be grouped under the "sms" folder. So that, that folder will now become a module.
I already have such a module at https://github.com/yeboahnanaosei/sms ๐Ÿ˜‰
It's a module that will hold several sms wrappers as and when I use them.

Containerise Project

Hey guys, some lovely stuff here.

I was trying to set up and it seemed this could use some containerisation.

A dockerfile and docker-compose files for redis, postgres, etc?

I could set this up over the weekend.

Great work this.

Error message from sms.New() is potentially misleading

The error message you get when you try to instantiate the sms package reads "mapbox key required"
This is a bit confusing because in my env I had set the mapbox key.

After investigating I realized that the system was actually looking for the TERMII_API_KEY environment variable. Setting that variable corrected the problem.

Seeing that the sms package is for TERMII, I feel the error message should be something like "TERMII_API_KEY" required or rather something more idiomatic like "sms: api key required"

There is a PR here: #16 (comment)

Database Table Migrations

There doesn't seem to be database table schema data in the project.

Screenshot 2021-01-23 at 23 58 06

My guess is this could be extracted from shared/types.go and database/models/*.go files

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:45 record not found
[0.779ms] [rows:0] SELECT * FROM "products" WHERE name = 'express' ORDER BY "products"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:45 record not found
[0.190ms] [rows:0] SELECT * FROM "products" WHERE name = 'pool' ORDER BY "products"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:74 record not found
[0.903ms] [rows:0] SELECT * FROM "couriers" WHERE first_name = 'griffith' AND last_name = 'awuah' ORDER BY "couriers"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:74 record not found
[0.229ms] [rows:0] SELECT * FROM "couriers" WHERE first_name = 'andy' AND last_name = 'osei' ORDER BY "couriers"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:74 record not found
[0.232ms] [rows:0] SELECT * FROM "couriers" WHERE first_name = 'yaw' AND last_name = 'manu' ORDER BY "couriers"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:103 record not found
[0.619ms] [rows:0] SELECT * FROM "customers" WHERE first_name = 'alicia' AND last_name = 'keys' ORDER BY "customers"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:158 record not found
[0.645ms] [rows:0] SELECT * FROM "vehicles" WHERE reg_number = 'GX 4888-10' ORDER BY "vehicles"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:158 record not found
[0.209ms] [rows:0] SELECT * FROM "vehicles" WHERE reg_number = 'GM 44-10' ORDER BY "vehicles"."id" LIMIT 1

2021/01/23 16:23:19 /Users/ispoa/Workspace/go/src/postmates/database/seeds.go:158 record not found

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.