gwenchee / 2021-chee-prelim Goto Github PK

Hi @gwenchee ! I'm through your prelim and i've left comments in the document here. Let me know if you need any clarification on anything.

This prelim is very good and well-written. Most of my comments are minor but I think could help enhance it and add clarification to help your reader. I added a few notes on what I think you should consider with your future work as well.

One major comment I have is that you should try to tie together the benchmark work with the optimization work a bit better. As this reads they are related, but not totally connected (with the exception that they are both on similar reactor types). Say how the benchmark work will help you in your optimization work (if it does) more clearly.

This issue closes #19 .

This issue can be closed when comments are addressed by @gwenchee

This issue can be closed after @npanczyk provides a review of the fourth chapter of my prelim:
2021-chee-prelim-03-01.pdf

2021-chee-prelim-04-24-edits.pdf

This looks great! Added just a couple comments, mostly grammatical/aesthetic. Let me know if you have any questions or want me to review again for anything in particular. Also, this issue can be closed when @gwenchee addresses my comments.

This issue can be closed after @katyhuff provides a review of chapter 5 & 6 of my prelim:
2021-chee-prelim-04-28.pdf

This issue can be closed after @npanczyk provides a review of the last chapter of my prelim:
2021-chee-prelim-04-24.pdf

2021-chee-prelim-04-06-edits.pdf

This issue can be closed when @gwenchee addresses my comments.

Here are the edits for chapter 5! I paid special attention to flow of logic, but everything made sense to me, so I'm sure an audience with more background will have no problems following either. Most comments were just grammatical or related to passive voice. I think you could probably introduce more "spunky" language (per checklist), but technically speaking, everything looks good. Also, there was one paragraph where you referred to the previous chapter and the verb tense was a little inconsistent. I think it should be past tense, but feel free to change it to present. Also, in terms of pronouns, not sure if it should be "we" or "I" because both show up, so if any of those seem inaccurate, that could be changed as well. Very interesting chapter though, and overall not a whole lot to change! Let me know if you have any questions and when you'd like me to read through another draft/the next chapter!

This issue can be closed after @npanczyk provides a review of the lit review chapter of my prelim:
2021-chee-prelim-01-20.pdf

Attached is my review of @gwenchee 's second chapter, with comments focused on logical flow (as requested) and a little bit of grammar. This issue can be closed when @gwenchee addresses these notes.
2021-chee-prelim-01-20-edits.pdf

2021-chee-prelim-03-01-edits.pdf
Overall, looks really good! Everything was clear to follow, just made some grammatical notes. I was a little confused in regard to referencing the "toolbox" because sometimes it was italicized and sometimes not, so that's something to check on (notes in doc as well). If anything, I think you could probably incorporate more "exciting verbs" (per writing checklist) overall, but it's also totally fine as is. If there's anything you'd like me to look for in particular, I'm happy to look over it again, just let me know! Apologies for the delay in getting this back as well.

This issue can be closed when @gwenchee implements comments as she sees fit.

This issue can be closed after @npanczyk provides a review of the fhr benchmark chapter of my prelim:
2021-chee-prelim-02-16.pdf

This issue can be closed when @gwenchee reviews my comments.
2021-chee-prelim-02-16-edits.pdf

Overall comments: Love the tables and figures in this chapter! Super clear, very visually appealing, and captions are thorough. In general, it does feel a little repetitive as you describe the set-up and such, which is in the nature of this kind of piece, I think. Still, if possible, I might suggest varying up the paragraph structure a bit to add variety. Everything seems to flow logically as well, couple grammatical things here and there, but nothing major. Let me know if there's anything else in particular you'd like me to look for/comment on, or if any of my notes are unclear, happy to go over it again.

This issue can be closed after @katyhuff provides a review of chapter 3 & 4 of my prelim:
2021-chee-prelim-03-08.pdf

This issue can be closed after @katyhuff provides a review of my full prelim:
2021-chee-prelim-07-18.pdf

This issue can be closed after @npanczyk provides a review of chapter 1 of my prelim:
2021-chee-prelim-01-15.pdf

This issue can be closed after @munkm provides a review of my prelim:
2021-chee-prelim-05-14.pdf

This issue can be closed when @gwenchee merges commits which handle the comments in the commented pdf below (edits on Feb 1 from katy).

2021-chee-prelim-01-31.pdf

I've completed the review in #17 , so this issue can now be closed when @gwenchee has handled the minor edits in the attached pdf! They're pretty minor, you've done a great job!
2021-chee-prelim-04-28.pdf

2021-chee-prelim-01-15-edits.pdf
This issue can be closed when @gwenchee addresses my comments.

This issue can be closed with a PR that handles the scribbled edits in the pdf below! Nice work!

2021-chee-prelim-03-08.pdf

This issue can be closed after @npanczyk provides a review of the fifth chapter of my prelim:
2021-chee-prelim-04-06.pdf

Could you pay special attention to the overall flow of the logic of the chapter? I go into detail about an example REALM problem and I'm not sure if it is confusing.

This issue can be closed after @katyhuff provides a review of chapter 1 & 2 of my prelim:
2021-chee-prelim-01-31.pdf