gvaughn / quest Goto Github PK

I am confused about the decision to always return a tuple with first element :error from defp handle_response({:ok, %Response{status_code: scode, body: body}}).

This is here:

It seems strange to always return an :error tuple. What is the reasoning behind it?

For the time being, I am using this modified version of the function (which seems simple and more fitting for every use case I have ):

# other http response code
 defp handle_response({:ok, %Response{status_code: scode, body: body}}) do
    case Jason.decode(body) do
      {:ok, json} ->
        {:ok, {scode, json}}

      # return unprocessed body
      _ ->
        {:error, {scode, body}}
    end
  end

Hi,

Do you think it would be a good idea to publish this package on hex.pm?

As far as I can see, it is fairly usable with reasonable defaults. The only problem would be the hard dependency to Ecto. I think it should be made optional like httpoison.