guyserfaty / nock-puppeteer Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 4.0 529 KB

Mock http requests with Nock.js in puppeteer

TypeScript 87.55% HTML 12.45%

nock-puppeteer's People

Contributors

Stargazers

Watchers

Forkers

signpost whatdandoes jondewoo

nock-puppeteer's Issues

Cannot `require` module

The ES5-style exports in the latest release break my old tests.

As per the documentation, I should be able to require the useNock module like this:

const useNock = require('nock-puppeteer');

As currently deployed, I accomplish the same thing like this:

const useNock = require('nock-puppeteer').default;

Here is the accompanying pull request: #12

Cannot read properties of undefined (reading toLowerCase) with puppeteer 14.4.0

Hey there 👋

I think puppeteer 14.4.0 introduced some changes inside HTTPRequest that break the current release of nock-puppeteer:

TypeError: Cannot read properties of undefined (reading 'toLowerCase')
      at node_modules/nock-puppeteer/lib/index.js:54:48
      at node_modules/nock-puppeteer/lib/index.js:48:5
      at node_modules/puppeteer/src/common/Page.ts:641:13
      at HTTPRequest.finalizeInterceptions (node_modules/puppeteer/src/common/HTTPRequest.ts:270:5)

But...! The changes introduced here work wonders with this new version, so I'm wondering why they haven't been released yet, is there a particular reason?

Regards,
Ugo

Recommend Projects