gustafl / excellibrary Goto Github PK

Does the library from the 0.1.x milestones still hold up after we add the writing methods?

The Sheet.Open() method was introduced for the sake of efficiency. Rather than loading all sheet contents automatically on Wordbook.Open(), you just load sheet metadata, and then use Sheet.Open() to load the sheet(s) you need explicitly.

But I realise now that this may be confusing. How are you supposed to understand that sheet contents are not loaded when the workbook is opened? Plus, it adds an extra line of code whenever the library is used. In the interest of achieving maximum intuitiveness, I plan to implement a boolean loadSheets option in WorkbookOptions, and make it default to true.

So rather than replacing Workbook.Open() with Sheet.Open(), it's probably better to let them both coexist. All sheets will be loaded by default when you open the workbook, unless you set the option to false and use Sheet.Open() to open sheets individually.

If the memory footprint of loading a small document turns out to be too excessive, however, I might consider changing the option's default to false.

The Open XML format allows for saving strings directly in the sheet files, rather than in sharedStrings.xml. These strings are called inline strings. There seem to be no way to get this behavior from Excel itself.

https://msdn.microsoft.com/en-us/library/office/documentformat.openxml.spreadsheet.inlinestring.aspx

This is relevant to ExcelLibrary when

1. saving to a workbook
2. reading from a workbook that has been generated by a tool other than Excel

This must be considered low priority, but support for inline strings should probably be added at some point.

The unit tests currently points to a file on my desktop, which is not included in the project. Not very useful. It would be nice to include a whole set of test files. Here's a video on how to do it:

http://channel9.msdn.com/Shows/Visual-Studio-Toolbox/Getting-Started-with-Unit-Testing-Part-2?wt.mc_id=player

Hi.
It doesn't parse cells with date and date cell type
for example

The name argument should take a column name, such as A1.

I think we do already, but let's find out and update the README accordingly.

Are they as simple as possible? In Row.AddCell() for instance, do we need to check the column index?

Workbook.Save() should, at the very least, be able to save new sheets, and sheet metadata. The question is if it should also save updated sheet contents, or if we should use a Sheet.Save() method for that. I'm leaning towards a single Workbook.Save() method for all writing operations.

It's inefficient to read all sheets if you only need one. So the Workbook.Open() method should no longer open and read sheet files (e.g. sheet1.xml). Implement Sheet.Open(string name) to load sheet data instead.