should import declarations reach renaming handlers? about jfstmerge HOT 5 CLOSED

@jvcoutinho it seems like we lost the filter that tries to match only elements of the same type. is that right @jvcoutinho?

from jfstmerge.

@jvcoutinho it seems like we lost the filter that tries to match only elements of the same type. is that right @jvcoutinho?

superimposition is matching properly (same name, same type), this is a issue only for the handler.

from jfstmerge.

That's weird, it's never happened to me. There are actually some filters in later steps, for example:
https://github.com/guilhermejccavalcanti/jFSTMerge/blob/b0f553b03e1c9eb6eb345af0754bf0526c81c860/src/main/java/br/ufpe/cin/mergers/handlers/MethodAndConstructorRenamingAndDeletionHandler.java#L178-L186

But this only constrains terminals to match methods, so I agree with you we could increase the robustness.
But since this method is the same as the one in #134, I suppose the problem is the same: the body ";" was marked as substring of the import statement's body. If it's body was empty (as it should be), this shouldn't be a problem.

from jfstmerge.

@jvcoutinho where should we add the check for trying to match only elements of the same type?

your second comment reinforces the need for improving the substring matching algorithm, right?

from jfstmerge.

That's weird, it's never happened to me. There are actually some filters in later steps, for example:

https://github.com/guilhermejccavalcanti/jFSTMerge/blob/b0f553b03e1c9eb6eb345af0754bf0526c81c860/src/main/java/br/ufpe/cin/mergers/handlers/MethodAndConstructorRenamingAndDeletionHandler.java#L178-L186

But this only constrains terminals to match methods, so I agree with you we could increase the robustness.
But since this method is the same as the one in #134, I suppose the problem is the same: the body ";" was marked as substring of the import statement's body. If it's body was empty (as it should be), this shouldn't be a problem.

@jvcoutinho the filter you mentioned only checks the left and right trees, as you can see below(the import came from the base, which is not filtered):

from jfstmerge.