Giter Club home page Giter Club logo

Comments (3)

guilhermejccavalcanti avatar guilhermejccavalcanti commented on August 22, 2024

When merging the triple:
image

There is no difference besides the blank lines. I was expecting that the flag --ignore-space-change would work for that, but it does not, and there is still a merge conflict:
image

So I suspected the flag was not working, or even not reaching all merging situation. However, when merging the same triple directly via git, invoking git's own flag, the result was the same:
image

The git manual says that "[...]the option ignores whitespace completely when comparing lines[...]"
I believe that they strictly consider whitespace, not including blank lines as in the example.

So, in principle, we have two options:

  1. Assume that this is correct, and leave as it is.
  2. Build upon that and include blank lines.

What do you think @pauloborba @jvcoutinho ?

from jfstmerge.

pauloborba avatar pauloborba commented on August 22, 2024

excellent point @guilhermejccavalcanti!

I believe that we should keep the git behavior, and explicitly explain that in the text that explains the flag --ignore-space-change

But have you tried the git option -Xignore-space-change too? I believe this should be the option we should use (look for ignore-space-change here https://git-scm.com/docs/git-diff) for comparison purposes.

Deleting a line doesn't seem to be considered a space change.

from jfstmerge.

guilhermejccavalcanti avatar guilhermejccavalcanti commented on August 22, 2024

But have you tried the git option -Xignore-space-change too? I believe this should be the option we should use (look for ignore-space-change here https://git-scm.com/docs/git-diff) for comparison purposes.

Same merge conflict with that option.

from jfstmerge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.