guangtianli / grpcalchemy Goto Github PK

• gRPCAlchemy version: 0.5.1
• Python version: 3.7.6
• Operating System: Windows

Description

gRPCAlchemy can't import generated proto files on Windows, see this error:

ModuleNotFoundError: No module named 'protos\hellomessage_pb2'

I think this is due to https://github.com/GuangTianLi/grpcalchemy/blob/master/grpcalchemy/utils.py#L104 and https://github.com/GuangTianLi/grpcalchemy/blob/master/grpcalchemy/server.py#L119 replacing '/' with '.', since on windows the directory separator is '\', as you can see from the error message.

Hope this helps :-)

• gRPCAlchemy version: 0.6.1
• Python version: 3.7.6
• Operating System: Windows

Description

I believe the windows issue #32 is still present in server.py on lines 192 and 195. gRPCAlchemy can't import generated proto files on Windows, see this error:

ModuleNotFoundError: No module named 'protos\hellomessage_pb2'

It looks to me like the fix applied to utils.py will do the trick for server.py. I will try to PR a fix asap, but wanted to let you know in the meantime.

Proposed fix, use:

if sys.platform == "win32":
    FILE_SEPARATOR = "\\"
else:
    FILE_SEPARATOR = "/"

This problem doesn't exist using linux. Thank you for this excellent library btw.

For my particular use-case I'd like to be able to invoke poco generation at build and packaging, not at gRPC runtime. Propose:

1. Adding a setting AUTO_GENERATE_POCOS (or similar) to settings with default to True (preserving current behavior), and;
2. providing a public API to invoke generation of pocos during the build.

Basically proposing to make the call to generate_proto_file in server.run optional.

Happy to do the work and PR, but thought I'd raise here.

The bot created this issue to inform you that pyup.io has been set up on this repo.
Once you have closed it, the bot will open pull requests for updates as soon as they are available.

The Philosophy of API design evolves from Flask to Django.

Origin API:

from grpcalchemy import Server, Context

app = Server('HelloService')

@app.register
def Hello(request: HelloMessage, context: Context) -> HelloMessage:
    return HelloMessage(text=f'Hello {request.text}')

if __name__ == '__main__':
    app.run()

Now:

from grpcalchemy import Server, Context, grpcservice

class HelloService(Server):
    @grpcservice
    def Hello(self, request: HelloMessage, context: Context) -> HelloMessage:
        return HelloMessage(text=f'Hello {request.text}')

if __name__ == '__main__':
    app = HelloService()
    app.run()