gta-reversed / gta-reversed-modern Goto Github PK

Describe the bug
There are a few classes that originally overwrote ProcessEntityCollision, yet we don't (which causes issues).
I've fixed CAutomobile in 11ed5a7, but there are still a few classes that don't override it. (CTrailer, CBoat, etc)

To Reproduce
See original VTables

https://www.youtube.com/watch?v=Fd897fF1q5g&feature=youtu.be

Incorrect then correct:

Faulty func: CFont::GetStringWidth

Arrow icons disappear after ~10 seconds from start.

Describe the bug
Right now classes with a c/dtor that isn't reversed will be double con/destructed, because when our ctor is called we call the original ctor, and then compiler will con/destruct all members over again.

To Reproduce
CPed is a good example: It has no reversed dtor. If one would add it, and just plugin::Call the original one they would experience a crash (likely in CMatrixLink)

Expected behavior
All classes with an c/dtor that hasn't been reversed should get reversed.

Additional context
Fixing this may fix quite some random issues.

I'm not sure, but I think it started happening 1-2 weeks ago.
Unsure what causes it, in the video I've tired:

• CWorld
• Occluder stuff
• 2DFx
  https://youtu.be/yqUIHJUqRWQ

Let's use floor, otherwise the compiler will complain:

    float width = std::floor(SCREEN_WIDTH_UNIT * 8.f);
    float height = std::floor(SCREEN_HEIGHT_UNIT * 8.f);

Originally posted by @Pirulax in https://github.com/Updated-Classic/gta-reversed-modern/pull/93#discussion_r790186207

Can't play missions (duh) and start a new game.

Faulty func: CClothes::RebuildCutscenePlayer

Faulty func: CPedIntelligence::FlushImmediately

Faulty func: CWorld::SprayPaintWorld

Most notably:

• CPlaceable (GetPosition, etc)
• CMatrix
• CTask's GetTaskType
  ... (add more)

Post all random crashes here, using the bug report template.

Turn on foggy weather through debug menu. There should be no fog in the interiors.

Untested:

• CCoverPoints - See PR
• C3dMarkers stub - See PR
• CPlaneTrails - See PR
• CPedList - See PR

Tested:

• CCheckpoints - See PR
• CBridge moderncpp - See PR
• CBouncingPanel - See PR
• CHeli on Sam's branch https://github.com/Updated-Classic/gta-reversed-modern/pull/174

Disabling CRadar::DrawRadarSprite will show difference.

Issue

Reproduce
Turn on foggy weather through debug menu.
Make sure CClouds::MovingFogRender is hooked.

"Little loop":

and sometimes the weirdness remains

Can't even load the mission "High Stakes, Low Rider"

Sometimes when entering to interior or vice versa, the door breaks.

Location

1-) Go to Unity Station
2-) CRASH!

stacktrace

• CRenderer::ScanSectorList - Problem with alpha on the road
• CRenderer::ScanBigBuildingList - Loop seems to go-on forever, and crashes in AddMovingEntityPtr (because numVisibleEntityPtrs is too high)
• CVisibilityPlugins. Produces bad render while only they hooked

Also maybe CRenderer::AddEntityToRenderList is wrong.

Try hook/unhook CRenderer::ScanBigBuildingList several time and bug will apear.

The original idea (Refer here for the final implementation):

Right now it's only possible to search by class name, but not by function name.
I propose the following format:

• <namespace (class)>::<function name>
• Just like in C++, it's possible to refer to the global namespace by typing :: (without anything before ::)
• If there's no :: or there's nothing after it we just filter the namespace list

Eg.:

• CWorld::Process - Should yield CWorld with all functions whose name starts with Process
• ::Process - All functions starting with Process
• Process:: - All functions inside the Process class/namespace
• Entity/:: - All functions inside the Entity category (Note the trailing / at the end - It is needed to differentiate between a class and category)
• Entity/Ped:: - Similar to above, but only show functions inside the Entity/Ped category.
• Entity:: - All functions inside the Entity class

For now this should be enough, in another PR fuzzy search could be added, to make stuff like:

• World::Process -> Would display all classes which contain the word "Word" and have a function whose name contains Process

The CStreaming::DeleteRwObjectsInSectorList crashes because entity is nullptr.

thats a 2D table, hence the multiply by 2.

constexpr struct {AnimationId animId; AssocGroupId assoc; } translation[] = {...};

(originally it was prob uint32[2][]

I'd recommend you use the struct method for clarity.

Also, the table seems to start at a lower address than IDA thinks (because 2 * 0 - 1 = -1).

Originally posted by @Pirulax in https://github.com/Updated-Classic/gta-reversed-modern/pull/29#discussion_r699641175

• Turns out Dumper uses disks... And I haven't implemented disks. (upd: Izzotop: MonsterTruck and cranes uses too)
• Also, there seems to be some collision bug when you stick the car to a wall.

I'm curious how long it might be before there is a standalone executable at the rate this project is moving? Further, once it does reach a complete state where it matches the original in function, would this project then start working on adding new features on top of the game? Like say optimizing it, fixing bugs, adding a few tweaks, and maybe custom textures and sounds to replace the original?

It should be similar to RH_ScopedInstall, but it should take the address of the _Reversed function instead.
Eg.: RH_ScopedVirtualInstall(GetTaskType, 0xdeadbeef) Should expand to something like InstallHook("ClassName", "GetTaskType", &GetTaskType_Reversed)

Adding this macro will get rid of the ugly _Reversed prefix in the GUI.

It would be really useful, because std::array has bound checking in debug mode, and it would help us in debugging a lot.
It has the same memory layout as a C-style array, so they're interchangeable.

All of them should've been exploded.

Faulty func: CExplosion::AddExplosion

ScanBigBuildingList causes a crash because it tries to add to many entities to the render list using AddEntityToRenderList (which is where it actually crashes, because ms_nNoOfVisibleEntities is incremented to some absurdly high value).

Unhooking it fixes the problem.

Describe the bug
Game still rings the phone for a frame-perfect time then dismiss while using a jetpack. Phone shouldn't ring at the first place.

To Reproduce
Steps to reproduce the behavior:

1. Load the save I uploaded below.
2. Get outside and enter the jetpack.
3. Wait for the phone ring, this is the bug.

Additional context

(took a while to catch the perfect frame 😄)

GTASAsf7.zip

Faulty func: CPhysical::??? (also punching bags after unhooked ApplyForce crashes the game)

Describe the bug
Incorrect fall animation.

To Reproduce
Steps to reproduce the behavior:

FindPlayerPed()->GetPosition() += { 0.0f, 0.0f, 2000.f };

Steps:

• Unhook CWorld::SprayPaintWorld. (#109)
• Spray all tags.
• Game will crash before Sweet calls you back.

Faulty func: CWorld::ClearExcitingStuffFromArea

Seems to happen only the first time they come out.
Unhooking CWorld::Process doesn't help.
Possible way to trace the issue may be to hook CWorld::Remove or CPopulation::RemovePed and see where it's called from.

Here's a list of stuff we gotta fix:

• #148
• #81
• #90
• #91
• Fix CWaterCannon (For whatever reason cannons are stuck in the air shooting water when a new game/save is loaded) #113
• Test CStats::FindMaxNumberOfGroupMembers crashes the game while recruiting - Only crashes for @yukani
• #159
• Grass -> 0x4106D0 then both 0x538440 and 0x5B5000 - Grass not visible on models
• Resolve bugs in CColStore::AddRef and CColStore::RemoveRef (see funcs)
• #83
• #103
• #111
• #112
• #119
• #117
• #118
• #142
• #149
• #121
• #164
• #171
• #185
• Fix CAutomobile
  • #248
  • #247
  • #244
  • #245
• #272

Faulty func: CWorld::SprayPaintWorld

Describe the bug
Starting Initial 2 mission crashes the game

To Reproduce

1. Start the Initial 2 mission

Screenshots

Additional context
Crashes in CCarGenerator, this is always 0xE27AB0 (Which causes a write access violation)

I'm playing in windowed mode, but when I wanna switch to fullscreen by pressing alt+enter game is crashing.

An option to "lock" hooks would be nice (that is, the hook's state can't be changed from the GUI).
Would be very useful in situations like #220 where we want to install hooks which always unhooked.

Instead of our asi we get imgui.

Faulty func: CDamageManager::GetWheelStatus

Describe the bug
The task pool (eg.: CPool) is full after some chasing by cops. Now, I'm not sure if it's because I was in a Rhino, but I'm pretty sure the vanilla game doesnt crash even when youre chased by the police in a Rhino.
From the video you can see I crash when there's a lot of stuff going on around me. I guess that's related as well.

To Reproduce

1. Take Rhino (I don't even think you need a vehicle)
2. Make yourself Wanted thru the cheat debug menu
3. Start running from them
4. Crash

Expected behavior
To not crash xddd

Screenshots
I'll post a video

Additional context
We probably have a mem leak somewhere. Good start would be the task manager/CPedIntel
dmp here

Describe the bug
See screenshot.

To Reproduce
Walk around

Screenshots

Additional context
Most likely introduced by e898575

Faulty func: CObject::SpecialEntityPreCollisionStuff_Reversed

This isn't really the issue of HooksModule, it's just where it "comes out".
It's SplitStringView being garbage (Sadly only C++23 has the required stuff that we'd need to get rid of this function).
Using tne range-constructor of string_view (c++23) it works fine, so I'll probably do that.
Until then, don't enter such strings :D

Edit:
Actually, the fix would be this I think:

if (&*rng.begin() != str.end()) {
    return std::string_view(&*rng.begin(), std::ranges::distance(rng));
} else {
    return "";
}