The first time I ran the script, I got warnings about nslookup not being installed (since it wasn't). However, the result thrown back by the test was correct. Then, I installed dns-utils and reran the program, and a different IP address was retrieved by the script. This IP address was incorrect.

I am running Debian Testing.

Hi, great script thanks for writing it.
I need to automatically add dns records for new servers, but I was getting update failed error when running. Looking through the code and Cloudflares API guide it looks like the script can only update an existing record (it uses PUT), I added an if check to see if it's adding/updating then use either POST or PUT depending on the action.

I genuinely dont understand GIT to submit my changes back :) so I'll just put it below:

# Perform record update
api_dns_update=`${curl_command} -s -X PUT "${cf_api_url}/zones/${zone_id}/dns_records/${record_id}" -H "X-Auth-Email: ${cf_email}" -H "X-Auth-Key: ${cf_api_key}" -H "Content-Type: application/json" --data "{\"id\":\"${zone_id}\",\"type\":\"A\",\"name\":\"${record_name}\",\"content\":\"${WAN_addr}\"}"`

Changed to:

# Perform record update
 if [ -z $record_id ]; then
     api_dns_update=`${curl_command} -s -X POST "${cf_api_url}/zones/${zone_id}/dns_records" -H "X-Auth-Email: ${cf_email}" -H "X-Auth-Key: ${cf_api_key}" -H "Content-Type: application/json" --data "{\"id\":\"${zone_id}\",\"type\":\"A\",\"name\":\"${record_name}\",\"content\":\"${WAN_addr}\"}"`
 else
     api_dns_update=`${curl_command} -s -X PUT "${cf_api_url}/zones/${zone_id}/dns_records/${record_id}" -H "X-Auth-Email: ${cf_email}" -H "X-Auth-Key: ${cf_api_key}" -H "Content-Type: application/json" --data "{\"id\":\"${zone_id}\",\"type\":\"A\",\"name\":\"${record_name}\",\"content\":\"${WAN_addr}\"}"`
 fi

Thanks again for writing it, I hope this helps someone.

Hi, that is great script thanks for it 👍

When running script it turns off Proxy (Turns cloud to grey) How can i stop this?

Thanks
dan

external_WAN_query='https://ifconfig.io/ip'

The site is currently down, which breaks the script.

Found that using named zone and named record generates errors.
due to curl version issue.... have no idea what version of curl is on there...
busybox ash is the cli -

due to the boxes being very small - there is not https certs installed sure that is a space issue.

so curl -k will allow the https to be insecure - not sure if there is a a work around for that.
However removing zone and record Id and only using names:

I believe its tied again to limited busybox / version of grep.

./cf-ddns.sh --get-zone-id
grep: unrecognized option: P
BusyBox v1.28.4 (2018-06-29 12:24:51 CEST) multi-call binary.

shows another issue in grep it looks like.
this simple change from -Po to -Eo doesn't work

so the regex is no bueno for busybox ash which is pretty common in most dd-wrt / router installs..

if you manually enter the records the script works great...

well except it thinks the LAN ip is the same as external... probably again due to different flavors of DD-WRT.

anyway pretty close - only issue I could find so far is that Grep is REALLY incompatible due to not being able to parse perl regex.

Hello,

it would be nice to be able to specify which interface name to get IP addresses from, and whether you want IPv4 or IPv6 (or both). For example:

• -i=eno1
• -t=A or -t=AAAA

I whipped up this script as a wrapper because cf-ddns.sh was getting an IPv6 address from the wrong interface (LAN) tried to update it to an A record:

#!/bin/sh

ip=`ip addr show eno1 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1`
email=""
api_key=""
zone=""
record=""

sh /usr/local/cf-ddns.sh/cf-ddns.sh    \
  -w=$ip                               \
  -e=$email                            \
  -a=$api_key                          \
  -z=$zone                             \
  -r=$record

{"success":false,"errors":[{"code":6003,"message":"Invalid request headers","error_chain":[{"code":6103,"message":"Invalid format for X-Auth-Key header"}]}],"messages":[],"result":null}