Rework Highlighter about markor HOT 13 CLOSED

thx!

Maybe check out https://stackedit.io/editor for this questions

from markor.

If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this.

Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner

from markor.

What do you mean by adding highlighting?

from markor.

To highlight markdown syntax. This is implemented already, but lacks a lot of elements right now.

from markor.

What additional elements do you want highlighted?

from markor.

e.g.:

• task list (gfm
• normal lists seem to be broken (when starting with a hypen - only)

from markor.

OK, I'll take this

from markor.

I have the issues you mentioned on the original PR fixed
How should things like ***text** and **text*** be handled?
what about ***text*** ?
I think I'm getting close to the limit of what can be accomplished with just regex.

from markor.

I put up a new PR for this. The only thing that isn't working is italics with two start characters and one end character. ie: **italics* or __italics_

from markor.

for simplicity and speed we can live with 99% being supported

from markor.

I broke bold with my previous PR. You merged it before I had a chance to fix it. My latest PR should fix it. Sorry about the sloppiness.

from markor.

np

from markor.

I think we are quite at the maximum what is possible with regexes. thanks for working.

closing.

from markor.