Method getItemId(position) of GsFileBrowserListAdapter may return the same ID about markor HOT 5 CLOSED

do they have the same filepath by chance, for some reason? I couldn't reproduce this problem yet.

from markor.

Create files Aa.md and BB.md in any folder, then long press Aa.md or BB.md.

These two files have the same hash value.

from markor.

References:

1. Two unequal objects with same hash code - Stack Overflow

2. Can Java's hashCode() produce same value for different strings? - Stack Overflow

3. Why can hashCode() return the same value for different objects in Java? - Stack Overflow

from markor.

Quick idea without too much complex thinking: To just sum orignal hashcode value and the modification unix time (numeric).

At the end, collision still can happen...but that should make it at least way less common. It adds a certain user-controllable part to the quotation too.

from markor.

Very interesting.

I propose this:

    @Override
    public long getItemId(final int position) {
        final File f = _adapterDataFiltered.get(position);
        final Long key = _fileIdMap.get(f);
        if (key == null) {
            final long newId = _lastAssignedId++;
            _fileIdMap.put(f, newId);
            return newId;
        } else {
            return key;
        }
    }

Its kinda brute force, but no collisions

from markor.