Comments (6)
gTBH it's relatively easy to pass in an Entry
using https://godoc.org/github.com/sirupsen/logrus#NewEntry
What are the benefitsof logrus.FieldLogger
above that?
from go-grpc-middleware.
It's an interface fulfilled by logrus.Entry
and logrus.Logger
as well. Also, I don't see how using Entry or Logger internals is necessary, so hiding those behind the FieldLogger API makes the code more stable by depending on a contract IMHO.
from go-grpc-middleware.
Sounds sensible. Wanna submit a PR? :)
from go-grpc-middleware.
Sure, but don't know when I will find some time to do so, so feel free to pick it if you want.
from go-grpc-middleware.
I started to take a stab at this, but the payload interceptor expects to be able to access the Data
variable of a logrus.Entry
returned from Extract
:
logEntry := entry.WithFields(Extract(ctx).Data)
It might be possible to return a logrus.Entry
for a logrus.FieldLogger
by calling logrus.WithFields(logrus.Fields{})
, but that feels dirty.
from go-grpc-middleware.
This is pretty old and we know have v2
code with different structure. Let us know if this is still important, we can reopen.
from go-grpc-middleware.
Related Issues (20)
- Support for WithSubsystem() HOT 5
- [retry-middleware] Stream is finished when retry timeout ends HOT 2
- Support loggging grpc status details HOT 1
- Add source and target endpoint as label for all client/server grpc metrics HOT 2
- Support ignore logging for v2(already attached PR) HOT 3
- Prometheus metrics label value inconsistency between Go and Java HOT 3
- [logging] disable option does not work with request/response fields HOT 6
- go-grpc-middleware/providers/openmetrics/v2 v2.0.0-rc.3 dependency of go-grpc-middleware/v2 v2.0.1 broken HOT 8
- Q: Logger migration HOT 2
- Support extensibility of retry condition
- [feat]: logging should loging grpc request msg HOT 1
- Example will log only first field HOT 3
- Add Capability to Override Base Timeout for Specific API HOT 1
- Use retry hooks for adding retry metrics
- logging.InjectFields does not work. HOT 1
- Use of golang.org/x/net/trace prevents dead code elimination HOT 1
- providers/prometheus v1.0.0 dependent on go-grpc-middleware v2.0.0-rc.3 HOT 6
- Feature: Auth Interceptor: Add support for partial per service AuthFunc override HOT 2
- WithDecider gone but referenced on documentation HOT 1
- Feature: protovalidate: Add custom ErrorConverter HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-grpc-middleware.